Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_resources should not depend on setuptools #311

Closed
ghost opened this issue Dec 24, 2014 · 3 comments
Closed

pkg_resources should not depend on setuptools #311

ghost opened this issue Dec 24, 2014 · 3 comments
Labels

Comments

@ghost
Copy link

@ghost ghost commented Dec 24, 2014

Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)


With the 8.0 release, and the vendoring of packaging, pkg_resources now imports setuptools, invoking the side effects of importing setuptools. This change violates the implicit expectation that pkg_resources should run independent of setuptools. I missed this violation during my review, but it should be relatively straightforward to correct.


@ghost
Copy link
Author

@ghost ghost commented Dec 24, 2014

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Add test making explicit the expectation that pkg_resources shouldn't import setuptools (or be dependent on it in any way). Ref #311.

@ghost
Copy link
Author

@ghost ghost commented Dec 24, 2014

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Move vendored packaging module into pkg_resources._vendor, restoring independence of pkg_resources from setuptools. Fixes #311.

@ghost
Copy link
Author

@ghost ghost commented Dec 25, 2014

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Include api_tests.txt in pytest invocation. Ref #312. Ref #311.

@ghost ghost added major bug labels Mar 29, 2016
@ghost ghost closed this Mar 29, 2016
@ghost ghost mentioned this issue Mar 29, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants