-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] 70.0.0 should state breaking change of removal of packaging.pkg_resources
#4376
Comments
Hi @davidxia, thank you for opening this issue, but I am afraid I disagree with the following conclusion:
You can see that https://github.com/pypa/setuptools/blob/v69.5.1/pkg_resources/__init__.py#L190-L273 i.e. This is a clear indicator that users should not expect an stable behaviour if they decide to run The fact that users were trying to run So my conclusion is that this is not a breaking change in terms of "API promises". |
This is how the Python docs describe
This is also further explained in PEP8:
|
Gotcha thanks for the explanation |
This is breaking PyTorch 2.1 (not PyTorch 2.2+). Will you consider adding it back?
|
Summary
69.5.1 had
packaging.pkg_resources
. I can runfrom pkg_resources import packaging
.But 70.0.0 seems to remove
packaging.pkg_resources
. Running frompkg_resources import packaging
errors withImportError: cannot import name 'packaging' from 'pkg_resources'
.Should this breaking change be stated in the changelog?
OS / Environment
tested on Linux Ubuntu 20.04.6 LTS, Python 3.10.13
Additional Information
minimal repro
from pkg_resources import packaging
works with 69.5.1from pkg_resources import packaging
fails with 70.0.0Code of Conduct
The text was updated successfully, but these errors were encountered: