Pin setuptools version #1114
Closed
Pin setuptools version #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1114
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 88fa3b0 with merge base f200da5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
=======================================
Coverage 26.74% 26.74%
=======================================
Files 183 183
Lines 8362 8362
=======================================
Hits 2236 2236
Misses 6126 6126 ☔ View full report in Codecov by Sentry. |
RdoubleA
approved these changes
Jun 24, 2024
|
How did you test this? @ebsmothers |
|
@joecummings I didn't yet. Will quickly create a new env to show this fixes the import error |
|
Actually the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1111, there is an import error when importing the setuptools
packagingAPI in versions >= 70.0. This is discussed on the setuptools repo here and on other downstream repos as well (see e.g. here). Going with the recommended solution from the second link and just pinning to 69.5.1 to resolve the issue.