New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep425tags: turn warning into a debug log entry #1332

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@tkhyn
Contributor

tkhyn commented Apr 18, 2018

@pganssle pganssle requested a review from benoit-pierre Apr 20, 2018

@pganssle pganssle merged commit af4e065 into pypa:master Apr 20, 2018

4 checks passed

codecov/patch 100% of diff hit (target 81.43%)
Details
codecov/project 81.43% (+<.01%) compared to e17cf0b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pganssle

This comment has been minimized.

Member

pganssle commented Apr 20, 2018

Should we change the warn parameter in any way? It doesn't actually raise a warning anymore, nor does it use log.warn.

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Apr 20, 2018

I'd rather keep the changes to a minimum so it's easier to merge-in updates from pip/wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment