Skip to content

Commit

Permalink
Run integration tests on PRs (#868)
Browse files Browse the repository at this point in the history
* Run integration tests on PRs

* Move integration tests to main workflow
  • Loading branch information
bhrutledge committed Feb 5, 2022
1 parent 37a3f87 commit b9a355c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 28 deletions.
28 changes: 0 additions & 28 deletions .github/workflows/integration.yml

This file was deleted.

16 changes: 16 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,21 @@ jobs:
name: ${{ matrix.python-version }} - ${{ matrix.platform }}
fail_ci_if_error: true

# Because the tests can be flaky, they shouldn't be required for merge, but
# it's still helpful to run them on PRs. See:
# https://github.com/pypa/twine/issues/684#issuecomment-703150619
integration:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: ${{ env.MIN_PYTHON_VERSION }}
- name: Install dependencies
run: python -m pip install tox
- name: Run tests
run: python -m tox -e integration

docs:
runs-on: ubuntu-latest
steps:
Expand All @@ -73,6 +88,7 @@ jobs:
needs:
- lint
- test
# Not requiring integration, because they can be flaky
- docs
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
runs-on: ubuntu-latest
Expand Down

0 comments on commit b9a355c

Please sign in to comment.