Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --skip-existing work for Artifactory indexes #363

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

mulmschneider
Copy link
Contributor

Artifactory repositories seem to return HTTP 403 when you try to upload
a package that already exists (and your user doesn't have overwrite
permissions).
Extend skip_upload to support this.

Artifactory repositories seem to return HTTP 403 when you try to upload
a package that already exists (and your user doesn't have overwrite
permissions).
Extend skip_upload to support this.
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #363 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   68.84%   68.89%   +0.05%     
==========================================
  Files          12       12              
  Lines         597      598       +1     
  Branches       95       95              
==========================================
+ Hits          411      412       +1     
  Misses        158      158              
  Partials       28       28
Impacted Files Coverage Δ
twine/commands/upload.py 66.27% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9806f4...74172b7. Read the comment docs.

@mulmschneider
Copy link
Contributor Author

I only noticed just now that there is already an existing PR for exactly this functionality: #326. I'm perfectly fine with closing this one in favor of #326.

Let me know if there is anything I can do to help to get either of them merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants