Restore prompts while retaining support for suppressing prompts #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=========================================
+ Coverage 79.94% 80.85% +0.9%
=========================================
Files 14 14
Lines 748 893 +145
Branches 108 141 +33
=========================================
+ Hits 598 722 +124
- Misses 114 132 +18
- Partials 36 39 +3
Continue to review full report at Codecov.
|
theacodes
approved these changes
Feb 9, 2019
theacodes
reviewed
Feb 9, 2019
| @@ -195,7 +195,7 @@ def get_userpass_value(cli_value, config, key, prompt_strategy=None): | |||
| """ | |||
| if cli_value is not None: | |||
| return cli_value | |||
| elif key in config: | |||
| elif config.get(key) is not None: | |||
There was a problem hiding this comment.
Always remember your none checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #450, the work in #426 had some unintended side-effects, namely that it unconditionally suppressed prompts for username and password (and thus also keyring resolution).
This PR goes back in time, committing tests to the code prior to #426 plus some commits on top of #426, then merges the two, fixing the failing tests.