Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch to 'main' #764

Closed
jaraco opened this issue Jun 12, 2021 · 10 comments
Closed

Rename default branch to 'main' #764

jaraco opened this issue Jun 12, 2021 · 10 comments

Comments

@jaraco
Copy link
Member

jaraco commented Jun 12, 2021

In order to improve inclusivity, many projects on Github including CPython and PyPA projects have migrated to 'main' as the default branch for the project.

Can we do the same here?

It's a mostly painless process but does require some toil for each of the maintainer's checkouts. It's best to do when there are no open pull requests, but even in that situation, the pull requests can be redirected.

I'll be happy to enact the change or advise.

@bhrutledge
Copy link
Contributor

I've been wondering about this, and fully support it. I don't think I have the permissions to do that.

@sigmavirus24
Copy link
Member

I don't have permissions to do it either. 🤷🏽‍♂️

@jaraco
Copy link
Member Author

jaraco commented Jun 12, 2021

It seems I did have access, so since there wasn't any objection, I just did it using this routine. There may be some cleanup to do, such as changing the protection settings (I was unable thusfar to remove the master branch).

@jaraco
Copy link
Member Author

jaraco commented Jun 12, 2021

After updating the branch protection rules to match main instead:

image

I was able to delete the master branch.

@jaraco
Copy link
Member Author

jaraco commented Jun 12, 2021

Probably the docs at readthedocs need to point to the new default branch. Could someone with access to that project update it? Also, while you're at it, please share admin access to the docs with me and other maintainers on the project. Thanks.

@sigmavirus24
Copy link
Member

I don't seem to have access to twine on RTD either. I feel like I used to have access to it but don't

@bhrutledge
Copy link
Contributor

Maybe @di?

@bhrutledge
Copy link
Contributor

The docs build is also failing, apparently due to the removal of setup.py, because RTD is running setup.py install --force.

https://readthedocs.org/projects/twine/builds/13994020/

A quick scan of the RTD docs suggests we might want to use a config file to change that setting: https://docs.readthedocs.io/en/stable/config-file/v2.html#packages

I'm happy to take this opportunity to learn more about RTD , but it looks like I would need to be added as a maintainer. According to https://readthedocs.org/projects/twine/, the current maintainers are @dstufft, @brainwane, and @di. Could one of y'all add me, @jaraco, and @sigmavirus24?

@di
Copy link
Sponsor Member

di commented Jun 18, 2021

@bhrutledge
Copy link
Contributor

Thanks @di! I updated the docs settings, and the build is passing. Since I think that was the only remaining task, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants