Allow for an HttpError without a response #1023
Conversation
twine/__main__.py
Outdated
| @@ -32,6 +32,9 @@ def main() -> Any: | |||
| try: | |||
| error = cli.dispatch(sys.argv[1:]) | |||
| except requests.HTTPError as exc: | |||
| if not exc.response: # pragma: no cover | |||
| raise | |||
There was a problem hiding this comment.
Re-raising because that follows the pattern of other unexpected exceptions. IE, I don't know what to do with an HTTPError that doesn't include a response.
There was a problem hiding this comment.
I can say with authority that types-requests is wrong and you should ignore this from mypy or typing.cast the response attribute.
Integration test is failing is a good sign this is the wrong change
There was a problem hiding this comment.
The source for RequestException (the base class of HttpError) seems to suggest that it is possible for exc.response to be None.
I thought the integration test failure was a pre-existing condition, but I see that's not the case. I don't understand why this changed caused it fail.
I switched to cast() in 0b73a90.
|
Not sure why the integration tests are failing, but we haven't let that be a blocker in the past. |
Hopefully this will fix the CI failures that started last week, probably as a result of types-requests 2.31.09.