Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Exceptions in keyring.get_password #316

Merged
merged 4 commits into from Mar 7, 2018
Merged

Suppress Exceptions in keyring.get_password #316

merged 4 commits into from Mar 7, 2018

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 7, 2018

Fixes issue reported in #315.

@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #316 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   67.42%   67.64%   +0.22%     
==========================================
  Files          12       12              
  Lines         574      578       +4     
  Branches       91       91              
==========================================
+ Hits          387      391       +4     
  Misses        162      162              
  Partials       25       25
Impacted Files Coverage Δ
twine/utils.py 85.14% <100%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bac420...3c939af. Read the comment docs.

Copy link
Contributor

@brainwane brainwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given this a short review and it looks fine, and I'm inclined to trust you on this as you wrote keyring and keyring support in twine originally. :) Thanks.

@brainwane brainwane merged commit 87905d5 into pypa:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants