Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer importlib_metadata for entrypoint parsing. #728

Merged
merged 4 commits into from Feb 21, 2021

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Jan 20, 2021

Fix for #338 (comment)

twine/cli.py Outdated Show resolved Hide resolved
Loading
@bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Jan 21, 2021

@jaraco It might be out of scope for this PR, but what do you think about completely removing pkg_resources as a dependency? Looks like the only other place it's used https://github.com/pypa/twine/blob/master/twine/package.py.

Loading

@jaraco
Copy link
Member Author

@jaraco jaraco commented Jan 21, 2021

@jaraco It might be out of scope for this PR, but what do you think about completely removing pkg_resources as a dependency? Looks like the only other place it's used https://github.com/pypa/twine/blob/master/twine/package.py.

I peeked at that briefly and decided it was out of scope, but I'm in favor of getting that out also, but separately.

Loading

@bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Jan 28, 2021

@jaraco I fixed the typing errors for 3.6 and 3.7 in 0d5aab4.

Is there anything else to do with this before merge? Maybe a changelog entry? 😉

Loading

@jaraco
Copy link
Member Author

@jaraco jaraco commented Jan 29, 2021

@jaraco I fixed the typing errors for 3.6 and 3.7 in 0d5aab4.

Thanks

Is there anything else to do with this before merge? Maybe a changelog entry? 😉

Done

Loading

@jaraco
Copy link
Member Author

@jaraco jaraco commented Feb 21, 2021

Consider merging please.

Loading

@bhrutledge bhrutledge merged commit 7e95990 into master Feb 21, 2021
41 of 42 checks passed
Loading
@bhrutledge bhrutledge deleted the feature/importlib-metadata-for-entrypoints branch Feb 21, 2021
@bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Feb 21, 2021

Happy to (though I guess assumed you would).

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants