Remove setup.py #757
Merged
Remove setup.py #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhrutledge
commented
May 26, 2021
jaraco
reviewed
May 26, 2021
tox.ini
Outdated
| @@ -100,7 +96,8 @@ setenv = | |||
| TWINE_USERNAME = {env:TWINE_USERNAME:__token__} | |||
| commands = | |||
| python -c "import path; path.Path('dist').rmtree_p()" | |||
| python -m pep517.build . | |||
| python -m build | |||
| python -m twine check --strict dist/* | |||
There was a problem hiding this comment.
FYI, In jaraco/skeleton, the fidelity of the readme is checked prior to release (as part of the test suite run) using pytest-checkdocs.
There was a problem hiding this comment.
And if it's broken by a PR sent by someone it needs to be fixed in a new PR. Which can't be done prior to a release. So we're wasting release manager cycles by pushing this until then and not checking it in a PR
There was a problem hiding this comment.
jaraco
reviewed
May 26, 2021
jaraco
reviewed
May 26, 2021
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
pipsupports editable installs with only setup.cfg files, andsetuptools_scmrecommendspyproject.toml, this seemed like a reasonable bit of housekeeping.Also referenced https://setuptools.readthedocs.io/en/latest/userguide/quickstart.html#basic-use.