Silence mypy errors related to importlib_metadata #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
reviewed
Apr 27, 2023
| @@ -118,6 +118,6 @@ def dispatch(argv: List[str]) -> Any: | |||
|
|
|||
| configure_output() | |||
|
|
|||
| main = registered_commands[args.command].load() | |||
| main = registered_commands[args.command].load() # type: ignore[no-untyped-call] # python/importlib_metadata#288 # noqa: E501 | |||
There was a problem hiding this comment.
FYI - importlib_metadata isn't tracking this issue any longer. Moreover, I'm not sure if importlib metadata were to supply a return type here that it would be compatible with the assumption that it's a callable. Probably a cast(Callable, ...) should be employed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't dug into this, but I'm guessing recent versions of mypy and/or importlib_metadata caused these new errors: