New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib64 symlink can break subtly since 16.1 #1248

Closed
wouterdb opened this Issue Nov 29, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@wouterdb
Contributor

wouterdb commented Nov 29, 2018

tldr

When creating a virtualenv on a path that contains a symlink, the virtualenv break if this symlink is removed due to the changes made in 5d56014

context

When running tests, we create a workspace folder for each test, which has a symlink to a shared virtual env. The first test case populates the virtualenv. Then the first testcase's workspace is removed.

Prior to 16.1 this worked as expected. However, in 16.1 the lib64 symlink is absolute (but not canonical). So when the workspace of the first test is removed, the shared virtual env breaks. The next test run produces the error "module pip not found".

fix

revert the change on line 1622 (5d56014#diff-51642b24ac9529f4baa0f483fa257d2dL1622)

wouterdb added a commit to inmanta/inmanta that referenced this issue Nov 30, 2018

Attempt to fix build stability (virtualenv)
* additional context capture
* found bug in virtualenv 16.1 pypa/virtualenv#1248
* removed old entries from tox.ini

gaborbernat added a commit that referenced this issue Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment