Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1168/1285] Implement tests for prompt behavior of activate.sh #1294

Closed
bskinn opened this issue Jan 28, 2019 · 0 comments · Fixed by #1330
Closed

[1168/1285] Implement tests for prompt behavior of activate.sh #1294

bskinn opened this issue Jan 28, 2019 · 0 comments · Fixed by #1330

Comments

@bskinn
Copy link

bskinn commented Jan 28, 2019

Per discussion at #1168 and #1285, as the first step of harmonizing the prompt handling behavior of the various supported shells, implement tests to confirm the following behaviors of activate.sh:

  • Obeys VIRTUAL_ENV_DISABLE_PROMPT
  • Implements default __VIRTUAL_PROMPT__, prompt prefix of "($VIRTUAL_ENV) ", when --prompt is not supplied
  • Creates __VIRTUAL_PROMPT__ prompt prefix from argument to --prompt without inserting a space
@bskinn bskinn mentioned this issue Jan 28, 2019
Closed
4 tasks
bskinn added a commit to bskinn/virtualenv that referenced this issue Feb 18, 2019
@bskinn
Complete tests for bash
86922aa 
Closes pypa#1294.
@bskinn bskinn mentioned this issue Feb 18, 2019
Closed
4 tasks
bskinn added a commit to bskinn/virtualenv that referenced this issue Mar 1, 2019
@bskinn
Complete tests for bash
677be37 
Closes pypa#1294.
@bskinn bskinn mentioned this issue Mar 1, 2019
Merged
4 tasks
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement prompt consistency tests and harmonize all activate scripts bskinn/virtualenv
1 participant
@bskinn