Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv should print help and return 2 #1556

Closed
nsoranzo opened this issue Feb 10, 2020 · 3 comments · Fixed by #1568
Closed

virtualenv should print help and return 2 #1556

nsoranzo opened this issue Feb 10, 2020 · 3 comments · Fixed by #1568

Comments

@nsoranzo
Copy link
Contributor

or anything greater than 0.

Behaviour pre v20:

(virtualenv16.7.9_venv) $ virtualenv --version
16.7.9
(virtualenv16.7.9_venv) $ virtualenv 
You must provide a DEST_DIR
Usage: virtualenv [OPTIONS] DEST_DIR

Options:
  --version             show program's version number and exit
...
(virtualenv16.7.9_venv) $ echo $?
2

New behaviour in v20.0.1:

(virtualenv20.0.1_venv) $ virtualenv --version
virtualenv 20.0.1 from /tmp/virtualenv20.0.1_venv/local/lib/python2.7/site-packages/virtualenv/__init__.pyc
(virtualenv20.0.1_venv) $ virtualenv 
(virtualenv20.0.1_venv) $ echo $?
0
@gaborbernat
Copy link
Contributor

gaborbernat commented Feb 10, 2020

The help is printed with --help\-h. All values have defaults so there's no reason why not just execute the create virtual environment command. Any reason why you want a help with no arguments, for example, the Linux command ls does not print help when you invoke it without arguments, so it's not like a mandatory requirement. Granted pre 20 we did, but we made the major bump exactly to not be shackled by such subtle differences.

@nsoranzo
Copy link
Contributor Author

Ah, it was not clear at all to me that it was creating a virtualenv in venv, closing in favour of #1557.

@gaborbernat
Copy link
Contributor

Hello, a fix for this issue has been released via virtualenv 20.0.2; see https://pypi.org/project/virtualenv/20.0.2/ (https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-2-2020-02-11) . Please give a try and report back if your issue has not been addressed; if not, please comment here, and we'll reopen the ticket. We want to apologize for the inconvenience this has caused you and say thanks for having patience while we resolve the unexpected bugs with this new major release.

thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants