Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for platformdirs v4 #2666

Closed
jwodder opened this issue Nov 11, 2023 · 14 comments
Closed

Update for platformdirs v4 #2666

jwodder opened this issue Nov 11, 2023 · 14 comments

Comments

@jwodder
Copy link

jwodder commented Nov 11, 2023

platformdirs v4.0 was released yesterday, yet virtualenv requires platformdirs<4. Please update virtualenv to accept the latest version of platformdirs.

@johnthagen
Copy link

I wanted to add that if a library you depend upon requires platformdirs, dependency resolution can select platformdirs 4.0.0, after which point, if another library depends on virtualenv, it will backtrack to virtualenv 20.4.7, which then is so old it can fail because of a SetuptoolsDeprecationWarning.

One such example:

@alex
Copy link
Member

alex commented Nov 13, 2023

5565034 was merged already, so this will be resolved whenever the next release happens

@kendra-human
Copy link

5565034 was merged already, so this will be resolved whenever the next release happens

Any rough ETA on when a release would occur?

@gaborbernat
Copy link
Contributor

Probably later this week, I'm currently in hospital for a few days unexpectedly so things got delayed, sorry.

@sigma67
Copy link
Contributor

sigma67 commented Nov 14, 2023

All the best @gaborbernat . Any other maintainers that could possibly jump in and help out?

@johnthagen
Copy link

@pfmoore I see you are listed as a maintainer on PyPI. Was wondering if you might be able to help out with this? ❤️

@pfmoore
Copy link
Member

pfmoore commented Nov 20, 2023

Nope, sorry. It's been quite a while since I worked on this repo, and I'm not sufficiently familiar with the current release process to want to try to do a release.

@sigma67
Copy link
Contributor

sigma67 commented Nov 21, 2023

Seems like it's as simple as creating a release on GitHub which will trigger the workflow: https://github.com/pypa/virtualenv/blob/main/.github/workflows/release.yml

But we can't be sure so it's probably better to wait for @gaborbernat

@gaborbernat
Copy link
Contributor

Seems like it's as simple as creating a release on GitHub which will trigger the workflow: main/.github/workflows/release.yml

Is more complicated because you need to use https://github.com/pypa/virtualenv/blob/main/tox.ini#L79 to update the changelog first. And then also create a zipapp via https://github.com/pypa/virtualenv/blob/main/tox.ini#L99 and do the release over pypa/get-virtualenv@779ff03

Finally create Github releases for both repos. Out now at https://pypi.org/project/virtualenv/20.24.7/

@johnthagen
Copy link

Thank you @gaborbernat! Hope you are doing well.

@gaborbernat
Copy link
Contributor

Thank you, relatively speaking to last week, I'm better, however, the full recovery will take some more time.

@sigma67
Copy link
Contributor

sigma67 commented Nov 21, 2023

Thank you, speedy recovery!

Might be a good idea to document this release process in the contribution/maintainer docs

@pfmoore
Copy link
Member

pfmoore commented Nov 21, 2023

Just to be clear, while I still have maintainer rights here, I wouldn't have done an emergency release for this even if the process had been documented. I don't think it's unreasonable for there to be a week or two's delay on something like this if the lead maintainer is unavailable. (Pip, for example, only does a release every 3 months).

I agree that having the various project processes documented is a good thing to do, but let's keep things in perspective here.

Best wishes for your recovery @gaborbernat!

@sigma67
Copy link
Contributor

sigma67 commented Nov 21, 2023

@pfmoore I did not intend to imply that you should have.

Just always helps to have things documented for critical packages just in case 👍

bobleckelibm added a commit to ibmresilient/resilient-python-api that referenced this issue Nov 22, 2023
virtualenv have added support for platformdirs 4.0
see pypa/virtualenv#2666
so we can remove our pins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants