New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VIRTUAL_ENV enviroment variable in activate_this.py #1057

Merged
merged 6 commits into from Dec 24, 2018

Conversation

Projects
None yet
10 participants
@nonylene
Copy link
Contributor

nonylene commented Jun 13, 2017

VIRTUAL_ENV was not set in activate_this.py, while set in other activate scripts.

@nonylene nonylene changed the title Set VIRTUAL_ENV enviroment in activate_this.py Set VIRTUAL_ENV enviroment variable in activate_this.py Jun 13, 2017

@gst

gst approved these changes Jul 10, 2017

@tgrant59

This comment has been minimized.

Copy link

tgrant59 commented Oct 5, 2017

👍

@ssbarnea
Copy link
Contributor

ssbarnea left a comment

Can you please refresh PR?

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Oct 6, 2017

Rebased against current master and ran bin/rebuild_script.py just now. (No changed)

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Oct 8, 2017

@pfmoore How about this pr?

@tgrant59

This comment has been minimized.

Copy link

tgrant59 commented Oct 13, 2017

@ssbarnea @gst This bug is causing us issues, do you think it could be merged soon?

@jcox-dev

This comment has been minimized.

Copy link

jcox-dev commented Oct 24, 2017

This would be nice to have in.

jcox-dev added a commit to ONSdigital/eq-survey-runner that referenced this pull request Oct 24, 2017

Remove virtual env warning from app script
virtualenv does not currently set the VIRTUAL_ENV environment variable when activate_this is used (pypa/virtualenv#1057). pipenv run uses activate_this rather than one of the other activation scripts. We should also not care about reporting a lack of virtual environment now that we use Pipenv.

jcox-dev added a commit to ONSdigital/eq-survey-runner that referenced this pull request Oct 24, 2017

Remove virtual env warning from app script
virtualenv does not currently set the VIRTUAL_ENV environment variable when activate_this is used (pypa/virtualenv#1057). pipenv run uses activate_this rather than one of the other activation scripts. We should also not care about reporting a lack of virtual environment now that we use Pipenv.
@hai-ld

This comment has been minimized.

Copy link

hai-ld commented Nov 27, 2017

Could this PR be merged soon?

@xavfernandez
Copy link

xavfernandez left a comment

A changelog would be nice 👍

@ssbarnea

This comment has been minimized.

Copy link
Contributor

ssbarnea commented Nov 27, 2017

@xavfernandez Thanks! I hope I will see more merges performed as current state of virtualenv is "kept in carbonite".

nonylene added a commit to nonylene/virtualenv that referenced this pull request Nov 27, 2017

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 27, 2017

@xavfernandez Thank you for response! I added a changelog in 86970de.

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 27, 2017

CI failed, I'm checking now 👀

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 27, 2017

setuptools requires Python '>=2.7,!=3.0.*,!=3.1.*,!=3.2.*' but the running Python is 2.6.6
ERROR: could not install deps [mock, pytest]; v = InvocationError('C:\\projects\\virtualenv\\.tox\\py\\Scripts\\pip.EXE install mock pytest (see C:\\projects\\virtualenv\\.tox\\py\\log\\py-1.log)', 1)

Oh, this is because setuptools dropped Python 2.6 support... pypa/setuptools#878

This patch is not relevant to that issue (should be fixed in another PR), so ready to merge!

@pradyunsg

This comment has been minimized.

Copy link
Member

pradyunsg commented Nov 27, 2017

You might want to merge master to fix the failing CI.

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 28, 2017

You might want to merge master to fix the failing CI.

Failed from the same reason. pytest also dropped 2.6 support today.

pytest-dev/pytest#2945

@twig

This comment has been minimized.

Copy link

twig commented May 11, 2018

This bug causes newrelic-plugin-agent setup.py to fail because VIRTUAL_ENV isn't set when installing via pipenv

What's preventing this from being released?

@gaborbernat gaborbernat force-pushed the pypa:master branch 6 times, most recently from 2b3f876 to 9dfcb43 Oct 22, 2018

@nonylene nonylene force-pushed the nonylene:set-virtual_env-env-activate_this branch from 8f435b1 to dd5dd56 Nov 14, 2018

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 14, 2018

I resolved conflicts and updated with ./bin/rebuild-script.py.

How about this pr? @gaborbernat

@gaborbernat
Copy link
Contributor

gaborbernat left a comment

I would like some tests for this to prevent regression in the future.

@nonylene nonylene force-pushed the nonylene:set-virtual_env-env-activate_this branch from dd5dd56 to 6338cb8 Nov 20, 2018

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 20, 2018

Regression test added: 6338cb8
Confirmed in Python 3.5.3 / 2.7.11 from Debian stretch.

(... and I've changed base commit to remove redundant merge commits.)

@gaborbernat
Copy link
Contributor

gaborbernat left a comment

nm

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Nov 23, 2018

Sorry but what does 'nm' mean?

@gaborbernat

This comment has been minimized.

Copy link
Contributor

gaborbernat commented Nov 23, 2018

never mind 😀

@gaborbernat gaborbernat self-assigned this Dec 16, 2018

@gaborbernat gaborbernat force-pushed the nonylene:set-virtual_env-env-activate_this branch from efb1540 to 6630913 Dec 23, 2018

nonylene and others added some commits Nov 20, 2018

Set VIRTUAL_ENV enviroment in activate_this.py
VIRTUAL_ENV was not set in activate_this.py, while set in other activate scripts.
fix

@gaborbernat gaborbernat force-pushed the nonylene:set-virtual_env-env-activate_this branch 5 times, most recently from 8f9be9d to db22eed Dec 23, 2018

@gaborbernat gaborbernat force-pushed the nonylene:set-virtual_env-env-activate_this branch from db22eed to f94024d Dec 23, 2018

@gaborbernat gaborbernat force-pushed the nonylene:set-virtual_env-env-activate_this branch from 76a3886 to da204fb Dec 24, 2018

@gaborbernat

This comment has been minimized.

Copy link
Contributor

gaborbernat commented Dec 24, 2018

This now passes the bar of merge-ability. Thanks everyone for the patience, this will be part of the early January release.

@gaborbernat gaborbernat merged commit 971d341 into pypa:master Dec 24, 2018

@nonylene

This comment has been minimized.

Copy link
Contributor

nonylene commented Dec 24, 2018

Thank you!

@nonylene nonylene deleted the nonylene:set-virtual_env-env-activate_this branch Dec 24, 2018

@gaborbernat gaborbernat added this to the 16.2 milestone Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment