Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get python versions from 32&64-bit registry views #1340

Merged
merged 5 commits into from
Apr 1, 2019
Merged

get python versions from 32&64-bit registry views #1340

merged 5 commits into from
Apr 1, 2019

Conversation

Tithen-Firion
Copy link

On Windows, get Python paths from both 32-bit and 64-bit registry views.

Additionally you get both major and minor versions, both with and without bitness information.

For example if you have versions 3.5 (32 bit), 3.5 (64 bit) and 3.6 (32 bit) you can choose from: 3.5-32, 3.5-64, 3.6-32, 3.5, 3.6, 3-32, 3-64 and 3, where:

  • 3 == 3.6-32 (because it has the highest version)
  • 3-32 == 3.6-32
  • 3-64 == 3.5-64
  • 3.5 == 3.5-64 (because 64-bit wins over 32-bit)
  • 3.6 == 3.6-32

virtualenv.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a changelog detailing the effect on users in detail 👌

@gaborbernat gaborbernat merged commit 124d0ed into pypa:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants