Add ruff, test latest OS and bump setuptools #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
force-pushed
the
ruff
branch
2 times, most recently
from
0e72539
to
78c5fc3
Compare
gaborbernat
force-pushed
the
ruff
branch
13 times, most recently
from
a65dca3
to
01ba626
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
for more information, see https://pre-commit.ci
gaborbernat
changed the title
ylecuyer
reviewed
Aug 2, 2023
| @@ -21,17 +21,17 @@ | |||
|
|
|||
|
|
|||
| def _get_path_extensions(): | |||
| return list(OrderedDict.fromkeys([""] + os.environ.get("PATHEXT", "").lower().split(os.pathsep))) | |||
| return list(OrderedDict.fromkeys(["", *os.environ.get("PATHEXT", "").lower().split(os.pathsep)])) | |||
There was a problem hiding this comment.
Looks like this syntax isn't compatible with all python version:
root@4ac062d1f6e7:~# python3 --version
Python 3.9.2
root@4ac062d1f6e7:~# virtualenv --version
virtualenv 20.23.1 from /usr/local/lib/python3.9/dist-packages/virtualenv/__init__.py
root@4ac062d1f6e7:~# virtualenv -p $(which python2) venv
RuntimeError: failed to query /usr/bin/python2 with code 1 err: ' File "/usr/local/lib/python3.9/dist-packages/virtualenv/discovery/py_info.py", line 24\n return list(OrderedDict.fromkeys(["", *os.environ.get("PATHEXT", "").lower().split(os.pathsep)]))\n ^\nSyntaxError: invalid syntax\n'
and the project is supposed to be compatible with
requires-python = ">=3.7"
There was a problem hiding this comment.
You're trying to create a Python 2 environment there, see https://virtualenv.pypa.io/en/latest/changelog.html#features-20-22-0 that's no longert supported. Use older version of the project, but really Python 2 is way past its EOL now.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernát Gábor bgabor8@bloomberg.net