Generalize Windows Tcl/Tk search; handle case where it's missing. #933

wants to merge 1 commit into


None yet

4 participants


This change copies over Tcl/Tk libraries on Windows into the virtualenv, but adds a check so handle the case where the libraries aren't present. Tcl/Tk is an optional component of the installation of Python 2 and 3. This also generalizes the search so either 8.5 or 8.6 are picked up, without needing to be aware of which Python versions ship with which Tcl/Tk version.

The goal here is to combine the solutions of #926 and #931 as a follow-up to #888 and #93.

I looked at the contributing guidelines and see that I should be making pull requests against develop, but that branch seems to have disappeared.

nodirt commented Jun 10, 2016

Currently we can't switch to the new version of virtualenv because we don't deploy tcl/tk. This PR will solve our problem.

lichray commented Jul 1, 2016

Just encountered this issue. Terrible.

@Ivoz Ivoz referenced this pull request Aug 1, 2016

Fix Tcl for Python 3.3- #926

Ivoz commented Aug 1, 2016

I've basically copied the approach in fead5d4 since the merge wasn't going to be clean. Thanks for approach.

@Ivoz Ivoz closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment