Generalize Windows Tcl/Tk search; handle case where it's missing. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Just encountered this issue. Terrible. |
Closed
|
I've basically copied the approach in fead5d4 since the merge wasn't going to be clean. Thanks for approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies over Tcl/Tk libraries on Windows into the virtualenv, but adds a check so handle the case where the libraries aren't present. Tcl/Tk is an optional component of the installation of Python 2 and 3. This also generalizes the search so either 8.5 or 8.6 are picked up, without needing to be aware of which Python versions ship with which Tcl/Tk version.
The goal here is to combine the solutions of #926 and #931 as a follow-up to #888 and #93.
I looked at the contributing guidelines and see that I should be making pull requests against
develop, but that branch seems to have disappeared.