Register Page / Registration Flow #334

toumorokoshi · 2014-08-08T07:44:29Z

Related to #322, this is a first draft at a registration page / registration flow. As of the initial pull request, it is the full workflow sans sending a confirmation e-mail, and and agreeing to a terms of use.

All we wanted were 4 random bytes in hex!

Simplify some code, use less confusing crypto nonsense

Fix #212 - Allow configuration of the search index

Document our current configuration options and format

Remove warehouse.download_statistics, it is now linehaul

Enable Warehouse to run on Python 3.3+, Python 2.7, and PyPy

Fix #190 - Document the requirement for uuid-ossp PostgreSQL extension

Enable the use of Camo to remove mixed content warnings

Implement the legacy XMLRPC search API

Convert new lines to line breaks when we can't render the description

Switch to using whitenoise instead of Werkzeug for static files

Document sentry's configuration

Use the new deterministic gzip support in whitenoie 0.12

toumorokoshi · 2014-08-08T07:49:21Z

I was trying to ensure compatibility with Pypi (in terms of data). Here's some notes I jotted down along the way:

pypi had the following requirements:
- username: begin and end with alphanumeric, allowing ._- in the middle
- email must be alphanumeric or in ._+@- (this is more or less covered with wtforms' email validator
- Email's are available until a user has successfully verified their account. Until then, the e-mail is not claimed.
the accounts_email table has a 'verified' column
- As far as I could tell, this column wasn't ever set to anything besides False. I originally thought it was used in the user verification somewhere, but I couldn't find code to validate my theory.
I had to modify engine logic.
- Using an 'engine' instance as the top level connection made it impossible to update the e-mail. It looks like sqlalchemy tries to guess what kind of executions need a commit at the end, and "WITH new_values..." (the query e-mail updating used) isn't one of them.
- I solved this by making a contextmanager that generates a transaction on every request, which is committed it the very end, and having db's always source the engine from the app.
- You can't rollback the top level transaction in the methods, but we couldn't do that before anyway. If we move to the pattern where the connection is passed along with the method, this'll give us the freedom of rolling back and transacting at will.
'itsdangerous' was added to handle signing and unsigning of keys. I added a secret_key parameter in dev/config.yml which is the seed passed into itsdangerous.
as discussed in Warehouse needs a register page #322, I didn't implement openid support or gpg key info, as it sounds like the future of those are up in the air.

Next Steps

If this looks like a good direction, I'm going to add the agreeing to the terms page, and also add the e-mail sending part of it.

r1chardj0n3s · 2014-08-18T05:06:17Z

tests/test_application.py

@@ -36,7 +36,7 @@ def test_basic_instantiation():
            "access_token": "testing",
        },
        "database": {
-            "url": "postgres:///test_warehouse",
+            "url": "postgres:///warehouse",


Is this change (and the one in tests/test_config.yaml) intentional?

r1chardj0n3s · 2014-08-18T05:30:11Z

Apart from the bizarro documentation build error and my couple of notes this looks good (huge changes get fewer comments dontcha know ;)

Not only is it not a valid HTTP header but it also doesn't exist in the API.

r1chardj0n3s · 2014-08-18T06:14:30Z

I've fixed the documentation error from master; please rebase.

* modified engine to query app directly, allowing transacted methods

* fixing tests with using a connections vs an engine directly * adding tests for user registration

* fixing tests * getting coverage to 100% * fixing flake8 issues

toumorokoshi · 2014-08-21T05:51:22Z

@r1chardj0n3s thanks! I realize I should probably do smaller commits, but it's a bit hard to chunk full workflows like this...

I'll definitely make sure to keep as small as possible though :)

dstufft · 2015-02-28T18:02:49Z

I'm not going to close this, but I've started porting Warehouse over to Pyramid to ease the concerns of the custom framework-ish thing I've got going on here. That work is on the pyramid branch inside this repository. I'm leaving this open because I'm going to need to port this PR over to that new branch, and I want to be able to re-use the work done here.

toumorokoshi · 2015-03-17T08:26:20Z

@dstufft ok! Let me know if you want any help with that: I'm happy to spend some time to port it over.

dstufft · 2015-03-17T11:10:56Z

If you want to do that, that'd be great :) I wasn't going to ask that since my decision to switch is what invalidated this PR but if you're willing to do that, it'd be great!

toumorokoshi · 2015-03-22T00:54:55Z

Anything I can do to help get Warehouse out there :) Just letting you know I'm going to start the work now. I don't have an ETA, but i'll start a pull request as soon as I have something.

dstufft · 2015-03-22T00:58:02Z

Awesome! If you need any help just let me know. Hopefully the new setup is easier to work on than before.

dstufft · 2015-05-04T11:32:50Z

@toumorokoshi is it helpful to you to have this Pull Request remain open while you work on getting register support into the Pyramid based Warehouse? If not I'll close it now that you're working on it.

toumorokoshi · 2015-05-04T18:24:21Z

Nope! Just wanted to let people know I'd like to tackle it, but I guess that's apparent now :)

alex and others added 30 commits March 2, 2014 15:01

Simplify some code, use less confusing crypto nonsense

0571105

All we wanted were 4 random bytes in hex!

I dont' even know

5c9b4c1

Fixed tests.

f5ed287

Fixed more tests.

e4f7f5d

Merge pull request #215 from alex/patch-2

ebc58cc

Simplify some code, use less confusing crypto nonsense

Fix #212 - Allow configuration of the search index

039176a

Merge pull request #214 from dstufft/configurable-search-index

4b55df2

Fix #212 - Allow configuration of the search index

Document our current configuration options and format

bd2d176

Merge pull request #216 from dstufft/sample-config

e46e221

Document our current configuration options and format

Remove warehouse.download_statistics, it is now linehaul

8997280

Merge pull request #217 from dstufft/remove-download-stats

38f5ec2

Remove warehouse.download_statistics, it is now linehaul

Switch Warehouse to be a Python 3.3+ Project

ef2f1bf

Restore compatability with CPython2.7

dbd7f94

Restore Compatability with PyPy

facded5

Merge pull request #218 from dstufft/python3

760d286

Enable Warehouse to run on Python 3.3+, Python 2.7, and PyPy

Fix #190 - Document the requirement for uuid-ossp PostgreSQL extension

6e8b61c

Merge pull request #219 from dstufft/update-dev-docs

02709a5

Fix #190 - Document the requirement for uuid-ossp PostgreSQL extension

Enable the use of Camo to remove mixed content warnings

c996152

Merge pull request #220 from dstufft/camouflage-http-image-urls

fbe5256

Enable the use of Camo to remove mixed content warnings

Implement the legacy XMLRPC search API

b927765

Merge pull request #221 from dstufft/xmlrpc-search

0a64810

Implement the legacy XMLRPC search API

Convert new lines to line breaks when we can't render the description

80aacf1

Merge pull request #222 from dstufft/better-rendering-invalid-rst

6f746ad

Convert new lines to line breaks when we can't render the description

Switch to using whitenoise instead of Werkzeug for static files

2a3a810

Merge pull request #223 from dstufft/better-staticfiles

0643429

Switch to using whitenoise instead of Werkzeug for static files

Document sentry's configuration

dc2b611

Merge pull request #224 from dstufft/document-sentry

158b755

Document sentry's configuration

Use the new deterministic gzip support in whitenoie 0.12

0a70749

Merge pull request #225 from dstufft/deterministic-gzip

fc584c4

Use the new deterministic gzip support in whitenoie 0.12

docs: Move Application Structure section before API

d06698f

r1chardj0n3s reviewed Aug 18, 2014
View reviewed changes

Remove invalid HTTP header "Link"

87d3403

Not only is it not a valid HTTP header but it also doesn't exist in the API.

toumorokoshi added 11 commits August 20, 2014 22:42

started on a registration form

1a21ed9

including validators from original pypi

5fdec23

Added created_account page + form to register

16a4cbc

* modified engine to query app directly, allowing transacted methods

Fixing and adding tests

0114024

* fixing tests with using a connections vs an engine directly * adding tests for user registration

adding more tests

5e5544a

adding itsdangerous, starting on confirmation workflow

e8d509c

started work on activation db method

ead8f8a

rewriting is_email_active with the proper logic

6046192

Finishing touches for v1 of registration flow

fca6e77

* fixing tests * getting coverage to 100% * fixing flake8 issues

adding 'secret_key' field to developer config

d487c3a

fixing some issues r1chardj0n3s pointed out

a872f2f

started working on email, fixing tests

b554c6e

dstufft force-pushed the master branch from 4f8a7df to ed15a09 Compare February 28, 2015 18:11

toumorokoshi mentioned this pull request Apr 26, 2015

register page - pyramids edition #507

Closed

toumorokoshi closed this May 4, 2015

demianbrecht mentioned this pull request Feb 18, 2016

Validate Complexity of Passwords #6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Register Page / Registration Flow #334

Register Page / Registration Flow #334

toumorokoshi commented Aug 8, 2014

toumorokoshi commented Aug 8, 2014

r1chardj0n3s Aug 18, 2014

r1chardj0n3s commented Aug 18, 2014

r1chardj0n3s commented Aug 18, 2014

toumorokoshi commented Aug 21, 2014

dstufft commented Feb 28, 2015

toumorokoshi commented Mar 17, 2015

dstufft commented Mar 17, 2015

toumorokoshi commented Mar 22, 2015

dstufft commented Mar 22, 2015

dstufft commented May 4, 2015

toumorokoshi commented May 4, 2015

Register Page / Registration Flow #334

Register Page / Registration Flow #334

Conversation

toumorokoshi commented Aug 8, 2014

toumorokoshi commented Aug 8, 2014

Next Steps

r1chardj0n3s Aug 18, 2014

Choose a reason for hiding this comment

r1chardj0n3s commented Aug 18, 2014

r1chardj0n3s commented Aug 18, 2014

toumorokoshi commented Aug 21, 2014

dstufft commented Feb 28, 2015

toumorokoshi commented Mar 17, 2015

dstufft commented Mar 17, 2015

toumorokoshi commented Mar 22, 2015

dstufft commented Mar 22, 2015

dstufft commented May 4, 2015

toumorokoshi commented May 4, 2015