Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Warehouse to run on Python 3.3+, Python 2.7, and PyPy #218

Merged
merged 3 commits into from Mar 3, 2014

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Mar 3, 2014

This PR:

  • Switches everything over to be written as Python3 "first" project
  • Uses psycopg2 instead of psycopg2cffi on CPython
  • Enables CPython 3.3+, CPython 2.7, and PyPy support

@alex
Copy link
Member

alex commented Mar 3, 2014

No more pypy?

@@ -67,7 +67,7 @@ def reindex(self, alias=True, keep_old=False):
def update_alias(self, alias, index, keep_old=False):
# Get the old index from ElasticSearch
try:
old_index = self.es.indices.get_alias(self._index).keys()[0]
old_index = list(self.es.indices.get_alias(self._index).keys())[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the .keys()

@dstufft
Copy link
Member Author

dstufft commented Mar 3, 2014

There we go, that should make @alex happier ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants