Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

ghost · 2022-06-17T05:09:50Z

This adds the functionality to add override attributes on review instances to generate Maya playblasts with custom resolutions, overriding asset settings resolutions.

To test this:

Create OpenPype Model instance.
Create camera and append under locator, animate locator to rotate around model.
Select camera and create OpenPype Review instance.
Publish.

If the resolution is set a value other than 0 on the Review instance custom attribute, the playblast generated and submitted to FTrack is going to have those values as its resolution. Otherwise, when it is set to 0, it will fallback and generate the playblast as per the asset's settings.

ghost · 2022-06-17T05:09:51Z

Task linked: OP-3088 Ability to sync asset resolution, playblast and review resolution

…playblast-and-review-resolution

openpype/hosts/maya/plugins/publish/extract_playblast.py

Simplify settings capture statement. Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

m-u-r-p-h-y

fails with error

also would like to ask about the logic.

it should check and set the resolution from the asset, not project settings

ghost · 2022-06-20T11:24:39Z

fails with error fails with error

also would like to ask about the logic.

it should check and set the resolution from the asset, not project settings

Ah, I'd misunderstood. Working on that now

m-u-r-p-h-y

still the same error

// pyblish.ExtractReview : Overscan color: #000000 //
// pyblish.ExtractReview : pixel_aspect: 1 //
// pyblish.ExtractReview : input_width: 1920 //
// pyblish.ExtractReview : input_height: 1080 //
// pyblish.ExtractReview : Output resolution is 0x0 //
// Error: pyblish.plugin : Traceback (most recent call last):
File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 332, in _render_output_definitions
File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 612, in _ffmpeg_arguments
File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 1325, in rescaling_filters
ZeroDivisionError: float division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "D:\REPO\OpenPype.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
runner(*args)
File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 79, in process
File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 247, in main_process
File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 346, in _render_output_definitions
NotImplementedError
Traceback (most recent call last):
File "", line 332, in _render_output_definitions
File "", line 612, in _ffmpeg_arguments
File "", line 1325, in rescaling_filters
ZeroDivisionError: float division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "D:\REPO\OpenPype.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
runner(*args)
File "", line 79, in process
File "", line 247, in main_process
File "", line 346, in _render_output_definitions
NotImplementedError //

ghost · 2022-06-20T12:07:01Z

This is happening because right now we're appending a resolution value through the review instance. I'll ping Ondrej and ask what he thinks

antirotor · 2022-06-20T16:54:28Z

Just adding here from internal communication:

I believe these (resolution attributes on created instance) should be set to asset resolution by default. Zero is used down the process to indicate that resolution should be used from the asset. So it should be like:

creator gets resolution from the asset
if zero is set here - project_settings/maya/publish/ExtractPlayblast/capture_preset/Resolution/width (and height) then nothing happens and asset resolution is propagated down the line, but if there is non-zero value, it should be used instead.

So creator has ability to override resolution but the default should be set from the asset. And if Extract Playblast has non-zero value, that should be used instead

…playblast-and-review-resolution

m-u-r-p-h-y

/ Error: pyblish.plugin : Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\extract_thumbnail.py", line 98, in process
  File "D:\REPO\OpenPype\openpype\vendor\python\common\capture.py", line 207, in capture
    _applied_viewport_options(viewport_options, panel)
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\contextlib.py", line 427, in enter_context
    result = _cm_type.__enter__(cm)
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\contextlib.py", line 112, in __enter__
    return next(self.gen)
  File "D:\REPO\OpenPype\openpype\vendor\python\common\capture.py", line 731, in _applied_viewport_options
    cmds.modelEditor(panel, edit=True, **options)
TypeError: Invalid flag 'lineAAEnable'
Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "<string>", line 98, in process
  File "D:\REPO\OpenPype\openpype\vendor\python\common\capture.py", line 207, in capture
    _applied_viewport_options(viewport_options, panel)
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\contextlib.py", line 427, in enter_context
    result = _cm_type.__enter__(cm)
  File "C:\Program Files\Autodesk\Maya2022\Python37\lib\contextlib.py", line 112, in __enter__
    return next(self.gen)
  File "D:\REPO\OpenPype\openpype\vendor\python\common\capture.py", line 731, in _applied_viewport_options
    cmds.modelEditor(panel, edit=True, **options)
TypeError: Invalid flag 'lineAAEnable' // 
b'Processing Extract Review'
// Error: pyblish.plugin : Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "D:\REPO\OpenPype\openpype\plugins\publish\extract_review.py", line 73, in process
KeyError: 'representations'
Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "<string>", line 73, in process
KeyError: 'representations' // 
b'Processing Extract burnins'
// Error: pyblish.plugin : Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "D:\REPO\OpenPype\openpype\plugins\publish\extract_burnin.py", line 79, in process
RuntimeError: Burnin needs already created mov to work on.
Traceback (most recent call last):
  File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
    runner(*args)
  File "<string>", line 79, in process
RuntimeError: Burnin needs already created mov to work on. //

ghost · 2022-06-27T13:41:51Z

Thank you @m-u-r-p-h-y please try to reset your project's settings and try again, it's propagating keys from the playblast options PR into this which breaks it!

m-u-r-p-h-y

You were right @Allan-I My settings from the previous PR messed up my settings. Now it is passing correctly.

with the explicitly set resolution it is not producing the correct output

m-u-r-p-h-y

I made sure I'm resetting the project settings first before testing this PR.

Now it does not behave properly. This is the output from script editor in maya which indicates we are not passing the correct values to playblast resolution:

'height': None, 'width': None,

// pyblish.ExtractPlayblast : Extracting capture.. // 
// pyblish.ExtractPlayblast : start: 1090, end: 1100 // 
// pyblish.ExtractPlayblast : Outputting images to C:\Users\murph\AppData\Local\Temp\pyblish_tmp_1gt397_1\reviewMain // 
// pyblish.ExtractPlayblast : using viewport preset: {'compression': 'jpg', 'format': 'image', 'quality': 95, 'off_screen': True, 'height': None, 'width': None, 'display_options': {'background': [0.49019607843137253, 0.49019607843137253, 0.49019607843137253], 'backgroundBottom': [0.49019607843137253, 0.49019607843137253, 0.49019607843137253], 'backgroundTop': [0.49019607843137253, 0.49019607843137253, 0.49019607843137253], 'displayGradient': True}, 'viewport_options': {'rendererName': 'vp2Renderer', 'displayLights': 'default', 'shadows': True, 'textures': True, 'twoSidedLighting': True, 'cameras': False, 'clipGhosts': False, 'controlVertices': False, 'deformers': False, 'dimensions': False, 'dynamicConstraints': False, 'dynamics': False, 'fluids': False, 'follicles': False, 'greasePencils': False, 'grid': False, 'hairSystems': True, 'handles': False, 'hud': False, 'hulls': False, 'ikHandles': False, 'imagePlane': True, 'joints': False, 'lights': False, 'locators': False, 'manipulators': False, 'motionTrails': False, 'nCloths': False, 'nParticles': False, 'nRigids': False, 'nurbsCurves': False, 'nurbsSurfaces': False, 'particleInstancers': False, 'pivots': False, 'planes': False, 'pluginShapes': False, 'polymeshes': True, 'strokes': False, 'subdivSurfaces': False}, 'viewport2_options': {'textureMaxResolution': 1024, 'enableTextureMaxRes': True, 'textureMaxResMode': 1, 'multiSampleEnable': True, 'multiSampleCount': 4, 'ssaoEnable': True}, 'sound': None, 'camera': '|camera1|cameraShape1', 'start_frame': 1090, 'end_frame': 1100, 'filename': 'C:\\Users\\murph\\AppData\\Local\\Temp\\pyblish_tmp_1gt397_1\\reviewMain', 'overwrite': True, 'viewer': False} // 
currentTime 1100 ;
// pyblish.ExtractPlayblast : playblast path  C:\Users\murph\AppData\Local\Temp\pyblish_tmp_1gt397_1\reviewMain.####.jpg // 
// pyblish.ExtractPlayblast : filename C:\Users\murph\AppData\Local\Temp\pyblish_tmp_1gt397_1\reviewMain // 
// pyblish.ExtractPlayblast : collection head reviewMain // 
// pyblish.ExtractPlayblast : we found collection of interest reviewMain.%d.jpg [1090-1100] // 
b'Processing Thumbnail'
// pyblish.ExtractThumbnail : Extracting capture.. // 
// pyblish.ExtractThumbnail : Using viewport preset: {'compression': 'jpg', 'format': 'image', 'quality': 95, 'isolate_view': True, 'off_screen': True, 'height': 0, 'width': 0, 'display_options': {'background': [0.49019607843137253, 0.49019607843137253, 0.49019607843137253], 'backgroundBottom': [0.49019607843137253, 0.49019607843137253, 0.49019607843137253], 'backgroundTop': [0.49019607843137253, 0.49019607843137253, 0.49019607843137253], 'displayGradient': True}, 'viewport_options': {'rendererName': 'vp2Renderer', 'displayLights': 'default', 'shadows': True, 'textures': True, 'twoSidedLighting': True, 'cameras': False, 'clipGhosts': False, 'controlVertices': False, 'deformers': False, 'dimensions': False, 'dynamicConstraints': False, 'dynamics': False, 'fluids': False, 'follicles': False, 'greasePencils': False, 'grid': False, 'hairSystems': True, 'handles': False, 'hud': False, 'hulls': False, 'ikHandles': False, 'imagePlane': True, 'joints': False, 'lights': False, 'locators': False, 'manipulators': False, 'motionTrails': False, 'nCloths': False, 'nParticles': False, 'nRigids': False, 'nurbsCurves': False, 'nurbsSurfaces': False, 'particleInstancers': False, 'pivots': False, 'planes': False, 'pluginShapes': False, 'polymeshes': True, 'strokes': False, 'subdivSurfaces': False}, 'viewport2_options': {'textureMaxResolution': 1024, 'enableTextureMaxRes': True, 'textureMaxResMode': 1, 'multiSampleEnable': True, 'multiSampleCount': 4, 'ssaoEnable': True}, 'sound': None} // 
// pyblish.ExtractThumbnail : Outputting images to C:\Users\murph\AppData\Local\Temp\pyblish_tmp_1gt397_1\reviewMain // 
currentTime 1090 ;

openpype/hosts/maya/plugins/publish/extract_playblast.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

m-u-r-p-h-y

testing scenario:

project_anatomy/attributes/resolution 1920x1080
project_settings/maya/publish/ExtractPlayblast/capture_preset/Resolution 0x0
review instance resolution 0x0
shot resolution in mongoDB set to 1080x1920

resulting playblast and thumbnail resolution 1080x1920 - CORRECT

project_anatomy/attributes/resolution 1920x1080
project_settings/maya/publish/ExtractPlayblast/capture_preset/Resolution 800x800
review instance resolution 0x0
shot resolution in mongoDB set to 1080x1920

resulting playblast and thumbnail resolution 1080x1920 - INCORRECT
we should have 800x800

project_anatomy/attributes/resolution 1920x1080
project_settings/maya/publish/ExtractPlayblast/capture_preset/Resolution 800x800
review instance resolution 1000x1000
shot resolution in mongoDB set to 1080x1920

resulting playblast and thumbnail resolution 1000x1000 - CORRECT

…tion.

m-u-r-p-h-y

After extensive testing resolution overrides work as expected.

1. Review Instance resolution has the top priority
if set to 0
2. project_settings/maya/publish/ExtractPlayblast/capture_preset/ resolution is used
if set to 0
3. shot/asset resolution is queried from database

Good job @Allan-I :)

Test resolution values against settings

d4df16b

ghost marked this pull request as draft June 17, 2022 05:10

ghost changed the title ~~OP-3088_Ability-to-sync-asset-resolution-playblast-and-review-resolution~~ OP-3088: Ability to sync asset resolution for playblasts from project settings. Jun 17, 2022

ghost added type: enhancement Enhancements to existing functionality host: Maya labels Jun 17, 2022

ghost self-assigned this Jun 17, 2022

Merge branch 'develop' into OP-3088_Ability-to-sync-asset-resolution-…

f4d6d1e

…playblast-and-review-resolution

ghost requested review from antirotor and mkolar June 17, 2022 10:38

iLLiCiTiT reviewed Jun 17, 2022

View reviewed changes

openpype/hosts/maya/plugins/publish/extract_playblast.py Outdated Show resolved Hide resolved

Allan I. A and others added 4 commits June 17, 2022 15:04

Update openpype/hosts/maya/plugins/publish/extract_playblast.py

0dfe3b6

Simplify settings capture statement. Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Add resolution overrides to creator.

d1b0c37

Add resolution overrides to collector.

eb3afe6

Correct resolution overrides in extractor

491e356

ghost marked this pull request as ready for review June 17, 2022 20:57

Add comments

594707f

mkolar requested review from m-u-r-p-h-y and removed request for mkolar June 20, 2022 07:46

m-u-r-p-h-y requested changes Jun 20, 2022

View reviewed changes

ghost changed the title ~~OP-3088: Ability to sync asset resolution for playblasts from project settings.~~ OP-3088: Ability to set resolution for playblasts from asset, and override through review instance. Jun 20, 2022

ghost requested a review from m-u-r-p-h-y June 20, 2022 11:49

m-u-r-p-h-y requested changes Jun 20, 2022

View reviewed changes

ghost marked this pull request as draft June 20, 2022 12:15

ghost force-pushed the OP-3088_Ability-to-sync-asset-resolution-playblast-and-review-resolution branch from fb08627 to 594707f Compare June 21, 2022 11:02

Allan Ihsan added 2 commits June 24, 2022 11:06

Fix comparison statements.

0c1688e

Fix comments.

c6d473f

ghost requested a review from iLLiCiTiT June 24, 2022 11:42

Allan Ihsan added 2 commits June 26, 2022 05:39

Merge branch 'develop' into OP-3088_Ability-to-sync-asset-resolution-…

384a44c

…playblast-and-review-resolution

Make appropriate feature fixes.

46bfbd2

ghost marked this pull request as ready for review June 27, 2022 08:43

mkolar requested a review from m-u-r-p-h-y June 27, 2022 12:36

m-u-r-p-h-y requested changes Jun 27, 2022

View reviewed changes

ghost requested a review from m-u-r-p-h-y June 27, 2022 13:41

m-u-r-p-h-y requested changes Jun 27, 2022

View reviewed changes

Allan Ihsan added 2 commits June 28, 2022 05:24

Rename attr into instance refactor.

409bf1b

Fix thumbnail extractor to match playblast resolution.

aca0c2a

mkolar requested a review from m-u-r-p-h-y June 28, 2022 10:20

m-u-r-p-h-y requested changes Jun 28, 2022

View reviewed changes

iLLiCiTiT reviewed Jun 28, 2022

View reviewed changes

openpype/hosts/maya/plugins/publish/extract_playblast.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Jun 28, 2022

View reviewed changes

openpype/hosts/maya/plugins/publish/extract_playblast.py Outdated Show resolved Hide resolved

Allan I. A and others added 7 commits June 28, 2022 18:20

Adjust dimensions to grab correct values from asset.

e9edb1c

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Simplify testing of cases for resolution

be2f9a0

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Variable rename.

c67308d

Simplify logic in thumbnail extractor.

bc18f8f

Change naming in interface.

4514ed8

Fix instance variable name.

92bf597

Fix asset data key.

9bfff7a

ghost requested a review from m-u-r-p-h-y July 1, 2022 13:38

m-u-r-p-h-y requested changes Jul 1, 2022

View reviewed changes

Allan Ihsan added 2 commits July 4, 2022 02:45

Alter final logic and change attribute naming to more pythonic conven…

ad9b01c

…tion.

Style fix.

8307ea8

m-u-r-p-h-y approved these changes Jul 4, 2022

View reviewed changes

mkolar merged commit adc90a4 into develop Jul 4, 2022

mkolar deleted the OP-3088_Ability-to-sync-asset-resolution-playblast-and-review-resolution branch July 4, 2022 13:04

mkolar changed the title ~~OP-3088: Ability to set resolution for playblasts from asset, and override through review instance.~~ Maya: Ability to set resolution for playblasts from asset, and override through review instance. Jul 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

ghost commented Jun 17, 2022 •

edited by ghost

ghost commented Jun 17, 2022

m-u-r-p-h-y left a comment •

edited

ghost commented Jun 20, 2022

m-u-r-p-h-y left a comment

ghost commented Jun 20, 2022

antirotor commented Jun 20, 2022 •

edited

m-u-r-p-h-y left a comment

ghost commented Jun 27, 2022

m-u-r-p-h-y left a comment •

edited

m-u-r-p-h-y left a comment

m-u-r-p-h-y left a comment

m-u-r-p-h-y left a comment

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

Conversation

ghost commented Jun 17, 2022 • edited by ghost

ghost commented Jun 17, 2022

m-u-r-p-h-y left a comment • edited

Choose a reason for hiding this comment

ghost commented Jun 20, 2022

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

ghost commented Jun 20, 2022

antirotor commented Jun 20, 2022 • edited

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

ghost commented Jun 27, 2022

m-u-r-p-h-y left a comment • edited

Choose a reason for hiding this comment

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

ghost commented Jun 17, 2022 •

edited by ghost

m-u-r-p-h-y left a comment •

edited

antirotor commented Jun 20, 2022 •

edited

m-u-r-p-h-y left a comment •

edited