Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

Merged
merged 24 commits into from
Jul 4, 2022
+55 −2
Merged

Maya: Ability to set resolution for playblasts from asset, and override through review instance. #3360

Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d4df16b
Test resolution values against settings
Jun 17, 2022
f4d6d1e
Merge branch 'develop' into OP-3088_Ability-to-sync-asset-resolution-…
Jun 17, 2022
0dfe3b6
Update openpype/hosts/maya/plugins/publish/extract_playblast.py
Jun 17, 2022
d1b0c37
Add resolution overrides to creator.
Jun 17, 2022
eb3afe6
Add resolution overrides to collector.
Jun 17, 2022
491e356
Correct resolution overrides in extractor
Jun 17, 2022
594707f
Add comments
Jun 17, 2022
0c1688e
Fix comparison statements.
Jun 24, 2022
c6d473f
Fix comments.
Jun 24, 2022
3968e16
Change logic into correct setting.
Jun 24, 2022
9778d27
Revert "Change logic into correct setting."
Jun 24, 2022
384a44c
Merge branch 'develop' into OP-3088_Ability-to-sync-asset-resolution-…
Jun 26, 2022
46bfbd2
Make appropriate feature fixes.
Jun 27, 2022
409bf1b
Rename `attr` into `instance` refactor.
Jun 28, 2022
aca0c2a
Fix thumbnail extractor to match playblast resolution.
Jun 28, 2022
e9edb1c
Adjust dimensions to grab correct values from asset.
Jun 28, 2022
be2f9a0
Simplify testing of cases for resolution
Jun 28, 2022
c67308d
Variable rename.
Jun 28, 2022
bc18f8f
Simplify logic in thumbnail extractor.
Jun 28, 2022
4514ed8
Change naming in interface.
Jun 28, 2022
92bf597
Fix instance variable name.
Jun 28, 2022
9bfff7a
Fix asset data key.
Jul 1, 2022
ad9b01c
Alter final logic and change attribute naming to more pythonic conven…
Jul 3, 2022
8307ea8
Style fix.
Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions openpype/hosts/maya/plugins/publish/extract_playblast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,21 @@ def process(self, instance):
)
preset = lib.load_capture_preset(data=self.capture_preset)

capture_presets = openpype.api.get_current_project_settings()["maya"]["publish"]["ExtractPlayblast"]["capture_preset"] # noqa
This conversation was marked as resolved.
Show resolved Hide resolved
width_preset = capture_presets["Resolution"]["width"]
height_preset = capture_presets["Resolution"]["height"]
preset['camera'] = camera

if width_preset == 0:
preset['width'] = instance.data.get("resolutionWidth")
else:
preset["width"] = width_preset

if height_preset == 0:
preset['width'] = instance.data.get("resolutionHeight")
else:
preset['height'] = height_preset

preset['start_frame'] = start
preset['end_frame'] = end
camera_option = preset.get("camera_option", {})
Expand Down