Webpublisher: cleanup wp extract thumbnail #4067
Merged
+7
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should handle all instance which has thumbnail representations, not only specifically for image and render. There might be many more.
Functionality will be replaced by ExtractThumbnailFromSource which handles resolution. Reviewable instance must contain thumbnailSource field pointing to source file for Thumbnail.
|
Task linked: OP-4371 Cleanup WP ExtractThumbnail |
64qam
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Removes obsolete
ExtractThumbnailfor webpublisher host which uses only ffmpeg.Description
Replaced by more explicit
ExtractThumbnailFromSourcewhich should be able to handle big resolutions.Also handles Overriding of integration of thumbnail representations into DB for all families.
Testing notes:
CollectPublishedFileshasCreate reviewtag for reviewable itemsCollectPublishedFiles), it should provide thumbnail for it in there. Depending onPreIntegrateThumbnailsSettings it should keep said thumbnail file in 'publish' folder next to real published file.