Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpublisher: cleanup wp extract thumbnail #4067

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Webpublisher: cleanup wp extract thumbnail #4067

merged 3 commits into from
Nov 4, 2022
+7 −141

Commits on Nov 3, 2022

  1. OP-4371 - remove families from PreIntegrateThumbnail 

    It should handle all instance which has thumbnail representations, not only specifically for image and render. There might be many more.
    @kalisp
    kalisp committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4874f5f View commit details
    Browse the repository at this point in the history

  2. OP-4371 - remove obsolete ExtractThumbnail 

    Functionality will be replaced by ExtractThumbnailFromSource which handles resolution.
Reviewable instance must contain thumbnailSource field pointing to source file for Thumbnail.
    @kalisp
    kalisp committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fa6a80b View commit details
    Browse the repository at this point in the history

  3. OP-4371 - fix - provide full path to first file as a source for Thumb… 

    …nail
    @kalisp
    kalisp committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    34f4ee5 View commit details
    Browse the repository at this point in the history