Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpublisher: cleanup wp extract thumbnail #4067

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Webpublisher: cleanup wp extract thumbnail #4067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4874f5f
OP-4371 - remove families from PreIntegrateThumbnail
kalisp Nov 3, 2022
fa6a80b
OP-4371 - remove obsolete ExtractThumbnail
kalisp Nov 3, 2022
34f4ee5
OP-4371 - fix - provide full path to first file as a source for Thumb…
kalisp Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions openpype/hosts/webpublisher/plugins/publish/collect_published_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ def process(self, context):
self.log.info("task_data:: {}".format(task_data))

is_sequence = len(task_data["files"]) > 1
first_file = task_data["files"][0]

_, extension = os.path.splitext(task_data["files"][0])
_, extension = os.path.splitext(first_file)
family, families, tags = self._get_family(
self.task_type_to_family,
task_type,
Expand Down Expand Up @@ -149,10 +150,13 @@ def process(self, context):
self.log.warning("Unable to count frames "
"duration {}".format(no_of_frames))

# raise ValueError("STOP")
instance.data["handleStart"] = asset_doc["data"]["handleStart"]
instance.data["handleEnd"] = asset_doc["data"]["handleEnd"]

if "review" in tags:
first_file_path = os.path.join(task_dir, first_file)
instance.data["thumbnailSource"] = first_file_path

instances.append(instance)
self.log.info("instance.data:: {}".format(instance.data))

Expand Down
137 changes: 0 additions & 137 deletions openpype/hosts/webpublisher/plugins/publish/extract_thumbnail.py
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions openpype/plugins/publish/preintegrate_thumbnail_representation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ class PreIntegrateThumbnails(pyblish.api.InstancePlugin):

label = "Override Integrate Thumbnail Representations"
order = pyblish.api.IntegratorOrder - 0.1
families = ["review"]

integrate_profiles = {}
integrate_profiles = []

def process(self, instance):
repres = instance.data.get("representations")
Expand Down