Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor bugfixes #4172

Merged
merged 5 commits into from Dec 9, 2022

Conversation

2-REC
Copy link
Contributor

@2-REC 2-REC commented Dec 5, 2022

Minor Bugs

@@ -915,7 +915,7 @@
"current_context": [
{
"subset_name_filters": [
"\".+[Mm]ain\""
".+[Mm]ain"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antirotor Can you confirm this is ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, there shouldn't be any double quotes

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked @antirotor for one confirmation otherwise looks good. Thanks

@antirotor antirotor added the type: bug Something isn't working label Dec 9, 2022
@antirotor antirotor merged commit 81f4369 into ynput:develop Dec 9, 2022
@github-actions github-actions bot added this to the next-patch milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants