Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.4 #128

Merged
merged 137 commits into from
Jul 3, 2019
Merged

Release version 0.4 #128

merged 137 commits into from
Jul 3, 2019

Conversation

afalaize
Copy link
Member

@afalaize afalaize commented Jul 1, 2019

  • comply with latest versions of dependencies
  • correct a lot of minor bugs
  • implement realizability analysis and simplification of linear graphs

pass tests and tutorials work but this currently breaks at least examples.rhodes

JNaj and others added 30 commits May 25, 2018 15:56
use
const <class> & func(args)
and "static" attributes inside funcs.
Use subprocess.call if subprocess.run does not exists. Note the output is not written in this case (in particular, the progrssbar is not displayed)
e.g. with state x = [x1, x2] and substitution dictionary subs = {x1: 1.} will make x1 pointing to (constant) parameter value instead of (variable) args vector element.
Add alternative to subprocess.run for python < 3.5
Warning: this implementation is not robust since it is only applicable to mono variate components but no verification tests are performed!
@ntonnaett
Copy link

I'm trying to get the rhodes example to work right now. Did you document somewhere what has changed for the new version? Can we get the rhodes example to work before the new release?

I had it working with a version of gdmcbain. Just the lowest velocity sounded wrong. I removed the load completely in config_simulation and changed the assembly of the different velocities to 'sig += list(simu.data['y'])'. But I didn't know what the load variables were for in the first place.

If I remember right, the normalization in the last wavwrite didn't work.

With the develop branch I've got a new error. I will open a bugreport for that.

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #128 into master will increase coverage by 2.6%.
The diff coverage is 81.99%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #128     +/-   ##
=========================================
+ Coverage   83.57%   86.18%   +2.6%     
=========================================
  Files         164      170      +6     
  Lines        7672     8665    +993     
=========================================
+ Hits         6412     7468   +1056     
+ Misses       1260     1197     -63
Impacted Files Coverage Δ
pyphs/examples/mka/mka.py 100% <ø> (ø) ⬆️
...fractional_derivator_fc/fractional_derivator_fc.py 100% <ø> (ø) ⬆️
pyphs/dictionary/edges/dissipatives.py 95.12% <ø> (ø) ⬆️
pyphs/misc/plots/multiplots.py 64.1% <ø> (ø) ⬆️
...actional_integrator_fc/fractional_integrator_fc.py 100% <ø> (ø) ⬆️
...fractional_derivator_ec/fractional_derivator_ec.py 100% <ø> (ø) ⬆️
pyphs/core/structure/moves.py 94.73% <ø> (ø) ⬆️
pyphs/examples/rhodes/rhodes.py 100% <ø> (ø) ⬆️
pyphs/examples/thielesmall_NL/thielesmall_NL.py 100% <ø> (ø) ⬆️
pyphs/examples/mka_dual/mka_dual.py 100% <ø> (ø) ⬆️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83a85f...79d751e. Read the comment docs.

@afalaize
Copy link
Member Author

afalaize commented Jul 2, 2019

most examples pass. Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants