-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 0.4 #128
Release version 0.4 #128
Conversation
use const <class> & func(args) and "static" attributes inside funcs.
Use subprocess.call if subprocess.run does not exists. Note the output is not written in this case (in particular, the progrssbar is not displayed)
e.g. with state x = [x1, x2] and substitution dictionary subs = {x1: 1.} will make x1 pointing to (constant) parameter value instead of (variable) args vector element.
Add alternative to subprocess.run for python < 3.5
Warning: this implementation is not robust since it is only applicable to mono variate components but no verification tests are performed!
version 0.4rc5
I'm trying to get the rhodes example to work right now. Did you document somewhere what has changed for the new version? Can we get the rhodes example to work before the new release? I had it working with a version of gdmcbain. Just the lowest velocity sounded wrong. I removed the load completely in config_simulation and changed the assembly of the different velocities to 'sig += list(simu.data['y'])'. But I didn't know what the load variables were for in the first place. If I remember right, the normalization in the last wavwrite didn't work. With the develop branch I've got a new error. I will open a bugreport for that. |
make rhodes example usable
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
+ Coverage 83.57% 86.18% +2.6%
=========================================
Files 164 170 +6
Lines 7672 8665 +993
=========================================
+ Hits 6412 7468 +1056
+ Misses 1260 1197 -63
Continue to review full report at Codecov.
|
most examples pass. Merge |
pass tests and tutorials work but this currently breaks at least
examples.rhodes