Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the project name to the basic-auth-with-2fa email. #11862

Merged
merged 5 commits into from
Jul 19, 2022

Conversation

Mariatta
Copy link
Contributor

Closes #11859

@Mariatta Mariatta requested a review from a team as a code owner July 16, 2022 03:26
@alex
Copy link
Member

alex commented Jul 16, 2022

This will include the project name in the jinja2 context, but won't actually include the project name in the email itself as far as I can tell -- I assume you want it in the email's body.

@Mariatta
Copy link
Contributor Author

Oh, yes! I'd forgotten to commit the email templates.
I've included them now: body.html and body.txt

Thank you.

@di di enabled auto-merge (squash) July 19, 2022 17:48
@di di merged commit 555a9a2 into pypi:main Jul 19, 2022
@Mariatta Mariatta deleted the issue-11859 branch July 19, 2022 17:55
di added a commit to di/warehouse that referenced this pull request Jul 20, 2022
di added a commit that referenced this pull request Jul 20, 2022
SamirPS pushed a commit to SamirPS/warehouse that referenced this pull request Aug 30, 2022
* Pass the project name to the basic-auth-with-2fa email.

Closes pypi#11859

* reformat

* Include the project name to the email template

* Add translation change

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
SamirPS pushed a commit to SamirPS/warehouse that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide the project name in the email for migrating to API tokens for uploading to PyPI
3 participants