tests: run postgres via pytest #15365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running a separate container, allow the pytest plugin to bootstrap its own postgres process. Increases the development image by adding the postgres server package. Changes the overall Docker runtime to run under a non-root user. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Now that pytest controls the server behavior during tests, remove from CI steps as well. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
added
testing
miketheman
commented
Feb 12, 2024
Further isolates development from testing by using `app_config` fixture instead of pulling the configuration from the environment. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
di
approved these changes
Feb 12, 2024
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
ewdurbin
approved these changes
Feb 16, 2024
|
Looks like I'll look for toggles that move that file |
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Feb 16, 2024
With the change to have the main container run as `nobody`, move some more application-root directories to `dev/`. Refs: pypi#15365 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Feb 16, 2024
With the change to have the main container run as `nobody`, move some more application-root directories to `dev/`. Refs: pypi#15365 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
di
added a commit
to di/warehouse
that referenced
this pull request
Feb 22, 2024
This reverts commit 51d7c35.
di
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running a separate container, allow the pytest plugin to
bootstrap its own postgres process.
Increases the development image by adding the postgres server package.
Changes the overall Docker runtime to run under a non-root user.
Signed-off-by: Mike Fiedler miketheman@gmail.com