Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "tests: run postgres via pytest (#15365)" #15444

Merged
merged 4 commits into from Feb 22, 2024
Merged

Revert "tests: run postgres via pytest (#15365)" #15444

merged 4 commits into from Feb 22, 2024

Conversation

di
Copy link
Member

@di di commented Feb 22, 2024

This reverts #15365, due to issues with having to set the nobody user with local development on Linux.

Closes #15430.

@di di requested a review from a team as a code owner February 22, 2024 00:54
@di di mentioned this pull request Feb 22, 2024
Closed
ewdurbin
ewdurbin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is the move for now

@miketheman miketheman added the testing Test infrastructure and individual tests label Feb 22, 2024
miketheman
miketheman approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, but otherwise 👍

tests/conftest.py Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@di di requested a review from miketheman February 22, 2024 16:26
@di di merged commit 1b0b150 into pypi:main Feb 22, 2024
17 checks passed
@di di deleted the revert/15365 branch February 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin ewdurbin approved these changes

@miketheman miketheman Awaiting requested review from miketheman

Assignees
No one assigned
Labels
testing Test infrastructure and individual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@di @miketheman @ewdurbin