Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Typography #179

Closed
wants to merge 9 commits into from
Closed

Basic Typography #179

wants to merge 9 commits into from

Conversation

bryanveloso
Copy link

Getting the basics out of the way.

@ghost ghost assigned bryanveloso Dec 29, 2013
@alex
Copy link
Member

alex commented Dec 29, 2013

Hey Brian, I don't have a deployment set up locally (lol) would you mind sharing a screenshot of how this looks?

@alex
Copy link
Member

alex commented Dec 29, 2013

You'll need to replace compass.rb with config.rb in MANIFEST.in

@bryanveloso
Copy link
Author

Currently looks like this:

2013-12-29 at 1 21 pm

@alex
Copy link
Member

alex commented Dec 29, 2013

Awesome, thanks.

@dstufft
Copy link
Member

dstufft commented Jan 1, 2014

Can you undo the theme_debug: true (keep that local only) and run inv static.build and commit the changes? You'll probably need to update tasks/static.py to understand the compass.rb -> config.rb change.

@dstufft
Copy link
Member

dstufft commented Jan 1, 2014

Oh, and the reason for the above is so that only people working on the theme require compass to be installed, and because inv static.build also invokes wake which the static url system uses to generate files with hashes in their name to cache break.

@dstufft
Copy link
Member

dstufft commented Jan 1, 2014

Also it looks awesome :D

@bryanveloso
Copy link
Author

I completely forgot you had invoke in there. D'oh. I'll revert all the things. 🙇

@dstufft
Copy link
Member

dstufft commented Jan 2, 2014

No worries!

@dstufft
Copy link
Member

dstufft commented Feb 15, 2014

Merged now with #199, thanks a ton @bryanveloso !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants