Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/allow search with pip #114

Merged
merged 8 commits into from
Jun 23, 2016

Conversation

blade2005
Copy link
Contributor

Example output

$ pip search --index http://127.0.0.1:8092 pypiserver
pypiserver                - 1.2.0.dev1
  INSTALLED: 1.2.0.dev1 (latest)
$ pip search --index http://127.0.0.1:8092 pypiserver9
$ 

The two additional libs in use are both part of standard python.

However unit testing hasn't been added yet. Trying to figure out how to get WebTest to understand and send xml

@blade2005 blade2005 mentioned this pull request Mar 4, 2016
@mplanchard
Copy link
Contributor

I like this. Is there any way you could add a unit test for the added functionality?

@blade2005
Copy link
Contributor Author

Thats on my list of things to do. I've just been super busy and need to sit down and understand how the testing framework is set up so I can emulate the rpc request.

@mplanchard
Copy link
Contributor

Glad to hear it, and there's no rush. Let me know if there's any way I can help.

On Mar 4, 2016, at 7:53 AM, Craig Davis notifications@github.com wrote:

Thats on my list of things to do. I've just been super busy and need to sit down and understand how the testing framework is set up so I can emulate the rpc request.


Reply to this email directly or view it on GitHub.

Removed unused imports
Added docstrings
Whitespace changes
PEP 008 compliance
Added test for search
@mplanchard
Copy link
Contributor

@blade2005 The PR against your branch contains a test for the search functionality. This doesn't address the issue where test_server is hanging on Travis for some reason. I'm looking into that now.

@mplanchard
Copy link
Contributor

I'm going to ahead and merge this

@mplanchard mplanchard merged commit 7aa9240 into pypiserver:master Jun 23, 2016
@blade2005 blade2005 deleted the topic/allow-search-with-pip branch June 23, 2016 12:47
@ankostis ankostis added this to the M1.2.0 milestone Jun 25, 2016
michaelkuty pushed a commit to michaelkuty/pypiserver that referenced this pull request Jun 27, 2016
@mplanchard mplanchard mentioned this pull request Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants