-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a separate cache for file digests #116
Conversation
Nice, |
- It's harder to make the listdir cache not recalculate, because when a file changes you need to only touch the file that changed. However, for file digests, the key is one-to-one, and very simple to invalidate. - This cache is especially useful when you have a lot of really large packages
Updated the commit, should work now... |
Also added a fix for --hash-algo=off in here, in case someone decides that approach is better for them. |
Very well! (are you still insisting not to participate to |
Yep. Just because I don't want to be on the team doesn't mean that I won't fix issues that affect me. :) |
Can we get unit tests for the new caching functionality? If not, I'll look into adding some this weekend. |
I was also not accustomed to pytest when I took over this project - and I think the setup of the fixtures is not optimal, but i still gave it a try and it is not completely worthless framework. |
@ankostis Sorry, when I said unit tests, I meant pytests. I use "unit test" as a generic catchall term for unit tests, pytests, nose tests, etc., which is perhaps not accurate of me. Pytest is fantastic, and any tests we add should use the pytest framework. |
Turns out, those file digests get really annoying if you have a hundred or so packages that are 40mb each (don't ask... ). This improves the cache and makes that less annoying.