Added a try/except for importing pam with logging an error and update…

[blade2005]

…d README to note that when using pam you need to install pam module

2016-06-24 16:54:27 pypiserver._app INFO <LocalRequest: POST http://127.0.0.1:8092/>
2016-06-24 16:54:27 pypiserver.core ERROR PAM module not found. Please install pam module
2016-06-24 16:54:27 pypiserver._app INFO 200 OK

[blade2005]

On a successful upload with pam

2016-06-24 16:55:39 pypiserver._app INFO <LocalRequest: POST http://127.0.0.1:8092/>
2016-06-24 16:55:40 pypiserver._app INFO User u'blade2005' stored 'pypiserver-1.2.0b1.zip'.
2016-06-24 16:55:40 pypiserver._app INFO 200 OK

[mplanchard]

Test failure looks like it may have been non-deterministic. Re-running.

[blade2005]

LOL. I was so very confused when I was looking at the test and the results disappeared from my screen.

[mplanchard]

The beauty of distributed testing 🔮

[mplanchard]

Looks like it may be a real problem

[blade2005]

o.O how does this one fail testing where the last one didn't. Looks like bad request got returned when trying to upload.

I tested it by hand and didn't see any issues.

# /usr/bin/pypi-server -r /packages -a '.' -P '.' -p 8092

removing 'pypiserver-1.2.0b1' (and everything under it)
running upload
Submitting dist/pypiserver-1.2.0b1.zip to http://127.0.0.1:8092/
Server response (200): OK

EDIT: Noticed it was failing for bdist and bdist_wheel.

running upload
Submitting /home/cdavis/pypiserver/dist/pypiserver-1.2.0b1-py2.py3-none-any.whl to http://127.0.0.1:8092/
Server response (200): OK
Submitting /home/cdavis/pypiserver/dist/pypiserver-1.2.0b1.linux-x86_64.tar.gz to http://127.0.0.1:8092/
Server response (200): OK

Still running fine. Might be something in the test env (mine or travis).

[mplanchard]

I’ll try running them again.

On Jun 24, 2016, at 12:11 PM, Craig Davis notifications@github.com wrote:

o.O how does this one fail testing where the last one didn't. Looks like bad request got returned when trying to upload.

I tested it by hand and didn't see any issues.

/usr/bin/pypi-server -r /packages -a '.' -P '.' -p 8092

removing 'pypiserver-1.2.0b1' (and everything under it)
running upload
Submitting dist/pypiserver-1.2.0b1.zip to http://127.0.0.1:8092/
Server response (200): OK
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #151 (comment), or mute the thread https://github.com/notifications/unsubscribe/AGcI4Rh8ldLrBGDMAUUrGYqGGpTlKhh-ks5qPA_KgaJpZM4I98Qs.

[mplanchard]

Hey, there we go.

[blade2005]

3rd time IS the charm then.

[ankostis]

Sorry :-(
We don't try/catch for missing dependencies - the original exception is quite explanatory to the user (in combination with the documentation, which is the one needing improvement).

[mplanchard]

Huh. I didn't know that. Want to pull it out?

[ankostis]

Yes, lets keep the code under diet :-) thanks!

[edit:] To be consistent, we would have to do the same also for passlib.apache - but we don't.

[mplanchard]

I'll have a PR up for that shortly

[mplanchard]

See #152

[ankostis]

@mplanchard please wait.
This PR is practically 2 lines of code + documentation:

import pam
..., auther=pam.authenticate)

why don't we keep everything to the documentation, and leave the new code for a future release, when updating the main() flags?

[mplanchard]

You mean the pam import in general? I suppose we could pull it out entirely and push it to the next release. Seemed like a pretty easy include with docs, though. Whatever you think is best.

[ankostis]

Commented in #152 what i suggest.