New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of deprecated inspect.getargspec #436
Replace usage of deprecated inspect.getargspec #436
Conversation
Hey @aronbierbaum! Thanks a lot for opening this PR 👍 I will check it out in detail in the coming days, but wanted to ask if you could provide a small context description in the PR description in the meantime? :) I see that it removes the |
916f945
to
254ac56
Compare
Hey @aronbierbaum, thank you for adding the description and making it backwards compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey @aronbierbaum, I have fixed the CI issues of #439 in #444. I think it should now check the things properly if you could update your branch with |
254ac56
to
d0ac79d
Compare
@dee-me-tree-or-love I have updated to be based off the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aronbierbaum, thanks a lot for the update! This looks great, thanks a lot for picking this up :) Glad to merge it.
Use
getfullargspec
for Python 3.x to support Python 3.11 wheregetargspec
was removed complete.