Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of deprecated inspect.getargspec #436

Merged

Conversation

aronbierbaum
Copy link
Contributor

@aronbierbaum aronbierbaum commented Aug 6, 2022

Use getfullargspec for Python 3.x to support Python 3.11 where getargspec was removed complete.

@dee-me-tree-or-love
Copy link
Member

Hey @aronbierbaum! Thanks a lot for opening this PR 👍 I will check it out in detail in the coming days, but wanted to ask if you could provide a small context description in the PR description in the meantime? :) I see that it removes the getargspec which was indeed deprecated in Python 3, but is still present in Python 2. I would like to double-check whether this will be a safe backward-compatible change before merging. What kind of problem specifically have you experienced with using the current version? :)

@dee-me-tree-or-love
Copy link
Member

dee-me-tree-or-love commented Aug 23, 2022

Hey @aronbierbaum, thank you for adding the description and making it backwards compatible.
I think it looks great and I'll be happy to merge it.
With #439, I might prefer to try fixing this first, but in any case, I will make sure to get your PR in.

Copy link
Member

@dee-me-tree-or-love dee-me-tree-or-love left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dee-me-tree-or-love
Copy link
Member

Hey @aronbierbaum, I have fixed the CI issues of #439 in #444. I think it should now check the things properly if you could update your branch with master. I will then give a final look and will be happy to merge this 👍

@aronbierbaum
Copy link
Contributor Author

@dee-me-tree-or-love I have updated to be based off the latest master.

Copy link
Member

@dee-me-tree-or-love dee-me-tree-or-love left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aronbierbaum, thanks a lot for the update! This looks great, thanks a lot for picking this up :) Glad to merge it.

@dee-me-tree-or-love dee-me-tree-or-love merged commit 784a9a1 into pypiserver:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants