Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xyc/liespline #224

Merged
merged 81 commits into from
Jul 13, 2023
Merged

Xyc/liespline #224

merged 81 commits into from
Jul 13, 2023

Conversation

XyC0212
Copy link
Contributor

@XyC0212 XyC0212 commented Apr 17, 2023

change the type of input and output to LieTensor

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Comment on lines 8 to 10
self.B = torch.tensor([[5, 3, -3, 1],
[1, 3, 3, -2],
[0, 0, 0, 1]]) / 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will have issues if inputs tensors is on GPU.

Copy link
Contributor Author

@XyC0212 XyC0212 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified the code
`
alpha = torch.arange(4, dtype=time.dtype, device=time.device)

    tt = time[:, None, :] ** alpha[None, :, None]

    B = torch.tensor([[5, 3, -3, 1],
                      [1, 3, 3, -2],
                      [0, 0, 0, 1]], dtype=time.dtype, device=time.device) / 6`

pypose/module/liesplinese3.py Outdated Show resolved Hide resolved
pypose/module/liesplinese3.py Outdated Show resolved Hide resolved
examples/module/liespline/liespline.png Outdated Show resolved Hide resolved
pypose/module/liesplinese3.py Outdated Show resolved Hide resolved
@wang-chen wang-chen mentioned this pull request Apr 18, 2023
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
@XyC0212 XyC0212 requested a review from wang-chen April 21, 2023 04:01
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
@XyC0212 XyC0212 marked this pull request as draft April 26, 2023 13:43
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
@XyC0212 XyC0212 requested review from wang-chen and MichaelFYang and removed request for wang-chen and MichaelFYang April 26, 2023 13:55
@XyC0212 XyC0212 marked this pull request as ready for review April 26, 2023 14:26
Copy link
Member

@wang-chen wang-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some overall comments:

  • No data is stored in the module, thus I suggest defining it as a function instead of a module.
  • many lines exceeding 90 characters. refer to 2nd point in developer guideline.
  • use tensor[..., i] to support batch operation instead of tensor[:, i], refer to 10th point in developer guideline.
  • some display issues in the doc, please view this pr doc

@wang-chen wang-chen added the new feature New feature or request label May 4, 2023
Signed-off-by: Chen Wang <chenwang@dr.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
It can support high dimensional data

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Support B spline of SE3 pass the origin pose

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
fix bugs

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
@XyC0212 XyC0212 requested a review from wang-chen June 24, 2023 13:17
wang-chen and others added 22 commits June 24, 2023 14:10
Signed-off-by: Chen Wang <chenwang@dr.com>
Adjust the length of lines

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Add wiki reference and delete dim==2

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
use the number of points as input parameter

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Update doc

Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
@wang-chen wang-chen merged commit cf6d5bb into pypose:main Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cubic-spline Interpolation in SE3
2 participants