-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xyc/liespline #224
Xyc/liespline #224
Conversation
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
pypose/module/liesplinese3.py
Outdated
self.B = torch.tensor([[5, 3, -3, 1], | ||
[1, 3, 3, -2], | ||
[0, 0, 0, 1]]) / 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will have issues if inputs tensors is on GPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have modified the code
`
alpha = torch.arange(4, dtype=time.dtype, device=time.device)
tt = time[:, None, :] ** alpha[None, :, None]
B = torch.tensor([[5, 3, -3, 1],
[1, 3, 3, -2],
[0, 0, 0, 1]], dtype=time.dtype, device=time.device) / 6`
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some overall comments:
- No data is stored in the module, thus I suggest defining it as a function instead of a module.
- many lines exceeding 90 characters. refer to 2nd point in developer guideline.
- use
tensor[..., i]
to support batch operation instead oftensor[:, i]
, refer to 10th point in developer guideline. - some display issues in the doc, please view this pr doc
Signed-off-by: Chen Wang <chenwang@dr.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
It can support high dimensional data Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Support B spline of SE3 pass the origin pose Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
fix bugs Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Chen Wang <chenwang@dr.com>
Adjust the length of lines Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Add wiki reference and delete dim==2 Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
use the number of points as input parameter Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Update doc Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
change the type of input and output to LieTensor