New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize clean_build_shapes #572
Finalize clean_build_shapes #572
Conversation
@ekatef This is what I think may be a finalized version of the PR. Once agreed the code, we need to finalize the documentation e.g. release_notes and config tables. |
2d2dced
to
2f9b4fb
Compare
@ekatef Please revise also including a comment on how to proceed for the release_docs. Before proceeding, I'd merge all my commits into a single one by resetting and merging everything again. |
Merging the PR once CI works. |
da0b7b0
to
af3ebdb
Compare
@davide-f, thank you :) I think it looks great and looking forward to see how it works globally Agree on that we both have to add configtables and can do it as a new PR. Touched with you suggestion on adding a release note :) But I'm also absolutely happy if you add a release note yourself as it could be much simpler |
I added your release note :) commit e196ac4 |
Closes # (if applicable).
This is a finalized version of the PR mainly edited by @ekatef in #563 and #570.
Big credits to @ekatef
Tested as follows:
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.