Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize clean_build_shapes #572

Merged
merged 6 commits into from Jan 23, 2023

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Jan 22, 2023

Closes # (if applicable).

This is a finalized version of the PR mainly edited by @ekatef in #563 and #570.
Big credits to @ekatef

Tested as follows:

  • PK with drop/set_by_country options
  • [IN, PK]

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member Author

davide-f commented Jan 22, 2023

@ekatef This is what I think may be a finalized version of the PR.
Please, add your comments so that we may finalize it.

Once agreed the code, we need to finalize the documentation e.g. release_notes and config tables.
I can quickly do that but as you mainly on it, you could do that as well.
Let me know how to handle it :)

scripts/build_shapes.py Outdated Show resolved Hide resolved
scripts/build_shapes.py Outdated Show resolved Hide resolved
scripts/build_shapes.py Outdated Show resolved Hide resolved
scripts/build_shapes.py Outdated Show resolved Hide resolved
scripts/build_shapes.py Outdated Show resolved Hide resolved
@davide-f
Copy link
Member Author

davide-f commented Jan 22, 2023

@ekatef Please revise also including a comment on how to proceed for the release_docs.
I realized that configtables are missing for build_shapes and created an issue for that. I won't be addressing that issue here so I'd proceed even without that option implemented.

Before proceeding, I'd merge all my commits into a single one by resetting and merging everything again.

@davide-f davide-f requested a review from ekatef January 22, 2023 23:37
@davide-f davide-f marked this pull request as ready for review January 22, 2023 23:44
@ekatef ekatef mentioned this pull request Jan 23, 2023
7 tasks
@davide-f
Copy link
Member Author

davide-f commented Jan 23, 2023

Merging the PR once CI works.
I've cherry-picked your commit and the PR seems ready to go. Let me know your thoughts :)

@ekatef
Copy link
Collaborator

ekatef commented Jan 23, 2023

@davide-f, thank you :) I think it looks great and looking forward to see how it works globally

Agree on that we both have to add configtables and can do it as a new PR. Touched with you suggestion on adding a release note :) But I'm also absolutely happy if you add a release note yourself as it could be much simpler

@davide-f
Copy link
Member Author

@davide-f, thank you :) I think it looks great and looking forward to see how it works globally

Agree on that we both have to add configtables and can do it as a new PR. Touched with you suggestion on adding a release note :) But I'm also absolutely happy if you add a release note yourself as it could be much simpler

I added your release note :) commit e196ac4

@ekatef ekatef mentioned this pull request Jan 23, 2023
7 tasks
@davide-f davide-f merged commit 4291a05 into pypsa-meets-earth:main Jan 23, 2023
@davide-f davide-f added this to the Country-wise model milestone Feb 1, 2023
@davide-f davide-f deleted the clean_build_shapes2 branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants