Shortcuts #268
Merged
Shortcuts #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new classmethod factory ctor to Pipeline to instantiate from config.shortcuts, if any matching requested pipeline_name exist. Initialize new pipeline from shortcut on pypyr.steps.pype, if matching found. Refactor pipelinerunner.run() also to use new factory ctor. Add pytest fixtures to intercept cls arg on Pipeline instantiation, allowing patching/mocking of Pipeline when invoked from the pipelinerunner/pype pipeline launch points. Rename shortcut pipe_arg to parser_args. Ref #267
Python's argparse looks like it has a (new) bug where `default` isn't honored on nargs. Result is that args_in nargs initialize to [] rather than None as specified. Therefore, change logic of Pipeline._get_parse_input to check truthy on args_in rather than `is None`. Amend shortcut logic to bypass run() parse_args bool switch, to allow shortcut to calculate whether to skip_parse or not. Ref #267.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pypyr.pipeline.Pipelinethat returns a newPipelinefromconfig.shortcutsif matching shortcut found.argparsemodule looks like it got a new bug in thatdefaultisn't honored on nargs.args_innargs initialize to[]rather thanNoneas specified and as it should.arg_parse=Falsewould just have redundantly run thecontext_parser, if it exists. But all the built-incontext_parsersdo a truthyNonecheck on the args input anyway, so this wouldn't have failed.Pipeline._get_parse_inputto check truthy onargs_inrather thanis None.pipinstall cache is supported by gh action nowadays so the tox configure step should be fast anyway. This might be the case, might not be, let's see.