Add helper method for running a simulation with grids of particles #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hscannell maybe you could have a look at this since you are doing particles with pyqg? |
… each fluid layer
asross
force-pushed
the
easier-particles
branch
from
b21c283
to
30fc70a
Compare
asross
force-pushed
the
easier-particles
branch
from
30fc70a
to
2510b9d
Compare
|
Let me know if this looks good to merge @hscannell! I also added a quick animated demo of this feature to |
rabernat
reviewed
May 16, 2022
| @@ -233,6 +237,35 @@ def __init__( | |||
| self._initialize_inversion_matrix() | |||
| self._initialize_diagnostics(diagnostics_list) | |||
|
|
|||
| def add_particles(self, initial_coords=None, order=1): | |||
There was a problem hiding this comment.
Suggested change
| def add_particles(self, initial_coords=None, order=1): | |
| def add_particles(self, density=0.125, initial_coords=None, order=1): |
|
|
||
| Parameters | ||
| ---------- | ||
|
|
There was a problem hiding this comment.
Suggested change
| density : float | |
| How many particles to put per grid cell. Mutually exclusive with ``initial_coords``. |
| """ | ||
|
|
||
| if initial_coords is None: | ||
| n = self.nx // 8 |
There was a problem hiding this comment.
Suggested change
| n = self.nx // 8 | |
| n = int(self.nx * density) |
or maybe something even better (non-discretized, using linspace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using particle classes to help visualize the results of pyqg simulations, I ended up writing some helper methods for running simulations with particles together, that seemed like they might be a useful feature for the main library. Here's an initial pass at how this might be incorporated, let me know what you think!