Cython updates #318
Open
Cython updates #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates Cython to use Python3-style semantics (including for division) and sets the NumPy API definition to silence deprecated API warnings. Generally following suggestions from Cython's migration guide for upcoming version 3.0.
Caused by the altered behavior with Cython language level 3.
Cython prange with a static schedule defaults to evenly dividing the work across threads. This also removes another float-to-integer assignment error.
The previous implementation called both PyFFTW and NumPy FFT through their Python interfaces. This code still does that, selecting which functions/methods to assign to class attributes when the class is constructed. There is some overhead from the conditions, but only while evaluating __init__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some of the flags in the Cython kernel
Cython seems to be in the process of releasing a version 3.0 which deprecates a few things. This should mostly follow their migration steps
This also removes the manual chunksize calculation since the default for the static schedule should divide the workload up evenly.
PyFFTW conditional compilation
One of the things it that seems to be under consideration for deprecation is conditional compilation (with
IF) used to select pyfftw/np (cython/cython#4310).The logic for selecting between the two is only run in the
PseudoSpectralKernel.__init__so we can instead do the selection at runtime.The existing implementation calls pyFFTW through the Python interface and this doesn't change that.
In the case of the NumPy FFT fallback there might be some slight overhead because of calling through a bound method object, but I would expect that to be small, and users almost certainly use pyFFTW since it is installed by default.