Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all testing code into the main library #2

Open
neerajprad opened this issue Oct 8, 2019 · 1 comment
Open

Move all testing code into the main library #2

neerajprad opened this issue Oct 8, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@neerajprad
Copy link
Member

As pointed out by @fritzo, any code in the test folder will be unusable by other projects, so it makes sense to move these to testing instead. Refer to pyro-ppl/pyro#2053 for details.

@fritzo
Copy link
Member

fritzo commented Oct 8, 2019

I've been thinking about this. I think it should be possible to register test cases in pytest-oblivious maner by creating an object with

  • a function (the name of this function will be used as test case)
  • a grid of test parameters that we can somehow thread to pytest.mark.parametrize

Again, it will help us design this interface to have more concrete tests to generalize from, e.g. MCMC, SVI, data generation, prediction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants