Add simple svi tests to pyroapi.tests

[fritzo]

Addresses #2

This is a good challenge to see how we can make tests generic.

Tasks

• add ones, zeros, randn to funsor.ops Add zeros, ones, randn to funsor.compat.ops funsor#270
• make funsor.svi raise a more targeted error when a pattern is missing Add PatternMissingError and use it for more informative failures in SVI funsor#271
• make minipyro.plate raise NotImplementedError on missing dim arg Exclude seed handler from the PYRO_STACK pyro#2061
• replace assert_close(-,-) with ops.allclose Add ops.allclose to funsor.compat.ops funsor#272
• make minipyro.param raise NotImplementedError on event_dim arg Deprecate pyro.generic in favor of pyroapi pyro#2062
• warn in NumPyro Add tests from pyroapi numpyro#396

Triaged

• fix funsor plate size error: test_data_generate_plate()

[fritzo]

@neerajprad Could you help me out with the last two remining NumPyro errors:

1. scipy.linalg._solve_toeplitz.array' has no attribute '__reduce_cython__'

2.RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject

[neerajprad]

Yes, taking a look at those errors now.

[neerajprad]

I am not able to replicate those failures. Could you point me to which tests are failing? The only failures that I see are Attribute error for.data not existing for jax arrays, and a bunch of NotImplementedErrors which xfail.

[fritzo]

1. the ufunc error is raised by test/test_tests.py::test_generate_data[numpy]
2. toeplitz error is raised by e.g. test/test_tests.py::test_generate_data_plate[numpy]

BTW I am running these on my mac. Should I do anything special to get an environment?

[neerajprad]

BTW I am running these on my mac. Should I do anything special to get an environment?

I don't think so, maybe just updating scipy should be fine? My scipy version is 1.3.1 and numpy is 1.17.2. Both of these tests pass if I remove the .data attribute.

[fritzo]

Thanks, it looks like this is a Python 3.7 issue; I can see passing tests on Python 3.6.

Looks like the last blocker is pyro-ppl/pyro#2062

[neerajprad]

Just merged #2062 in Pyro.

[fritzo]

I'll fix the .data bug and push.

[neerajprad]

I agree, it will makes more sense to have this in pyro-api instead.

[neerajprad]

Looks great. I will try to increase coverage in numpyro once this merges.