Add tests from pyroapi #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
reviewed
Oct 11, 2019
| 'test': [ | ||
| 'flake8', | ||
| 'pytest>=4.1', | ||
| 'pyro-api@https://api.github.com/repos/pyro-ppl/pyro-api/tarball/master' |
There was a problem hiding this comment.
👍 I'll use this method in funsor as well: pyro-ppl/funsor#267
| @@ -0,0 +1,7 @@ | |||
| class UnsupportedAPIWarning(Warning): | |||
There was a problem hiding this comment.
Looks great! If this class proves useful, we may want to move it to pyroapi, maybe calling it a NotImplementedWarning to match NotImplementedError.
fritzo
reviewed
Oct 11, 2019
fritzo
previously approved these changes
Oct 11, 2019
fritzo
previously approved these changes
Oct 11, 2019
|
|
fritzo
reviewed
Oct 11, 2019
fritzo
approved these changes
Oct 12, 2019
|
Can we merge this to unblock pyro-ppl/pyro-api#5 ? |
6 tasks
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses pyro-ppl/pyro-api#2.