Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logistic growth tutorial #2982

Merged
merged 8 commits into from
Dec 10, 2021
Merged

Add logistic growth tutorial #2982

merged 8 commits into from
Dec 10, 2021

Conversation

martinjankowiak
Copy link
Collaborator

@martinjankowiak martinjankowiak commented Dec 7, 2021

@martinjankowiak
Copy link
Collaborator Author

our notebooks assume that pyro is installed which is not the case for colab. do we just make a second copy of the notebook that has the pip install at the top?

@martinjankowiak
Copy link
Collaborator Author

  • typo: +to => "Next let's extract sublineages corresponding two of the"
  • arguably rate_scale isn't doing much in the last model since there are only two lineages
  • typo: generalization section => "usepyro.plate"

generally looks great and i think this will be a good fit for the workshop

Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this @martinjankowiak!

@martinjankowiak
Copy link
Collaborator Author

thank for your substantial improvements!

@fritzo fritzo merged commit 7e84004 into dev Dec 10, 2021
@fritzo fritzo deleted the add-logistic-growth-tut branch December 10, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants