Drop more references to Python 3.6 #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the Unless it's being used for CI or something, seems like it could just be removed. But maybe some people on the team are using it for development? I'm curious if they have their own updated version. |
|
@jamestwebber I really have no idea who uses the docker file. It might be an old holdover from @neerajprad's days at Uber 🤷 |
fehiepsi
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops more references to Python 3.6, following up on #3045
@jamestwebber one reference that remains is the docker/Makefile, which seems to use python==3.6 and an ubuntu image from 2016. Yikes actually, the Dockerfile is still on Python 2.7. I guess we should update this to Python 3.7 and a 2020 image? Or should just we wait until users ask for an update?