Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProvenanceTensor to use pytree #3223

Merged
merged 3 commits into from
May 29, 2023
Merged

Refactor ProvenanceTensor to use pytree #3223

merged 3 commits into from
May 29, 2023

Conversation

ordabayevy
Copy link
Member

This PR:

  • Removes __init__ method
  • Refactors the code to use pytree to track/extract provenance

fritzo
fritzo reviewed May 28, 2023
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests of track_provenance()? It'd be nice to have tests before we refactor it.

@ordabayevy ordabayevy requested a review from fritzo May 29, 2023 03:26
fritzo
fritzo approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@fritzo fritzo merged commit b131230 into dev May 29, 2023
9 checks passed
@ordabayevy ordabayevy deleted the provenance-pytree branch May 29, 2023 03:45
@francois-rozet francois-rozet mentioned this pull request Jul 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ordabayevy @fritzo