feat: add fields to store when an event was acknowledged and by whom #278
Conversation
…274) - add acknowledged_ts and acknowledged_by to events table - Dockerfile-dev: update FROM image
|
Nice of you to open a PR 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 95.12% 95.38% +0.26%
==========================================
Files 63 66 +3
Lines 1497 1582 +85
==========================================
+ Hits 1424 1509 +85
Misses 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks @fe51 ! There was a problem that caused the client tests to fail: I was recording the access_id instead of the user_id in events/acknowledge_by. This is fixed now. |
|
Thanks a lot @blenzi |
| @@ -28,9 +28,12 @@ class Event(Base): | |||
| start_ts = Column(DateTime, default=func.now()) | |||
| end_ts = Column(DateTime, default=None, nullable=True) | |||
| is_acknowledged = Column(Boolean, default=False) | |||
| acknowledged_by = Column(Integer, ForeignKey("users.id")) | |||
| acknowledged_ts = Column(DateTime, default=None, nullable=True) | |||
There was a problem hiding this comment.
to follow the other named fields, perhaps a "acknowledged_at"?
| @@ -23,6 +23,7 @@ class User(Base): | |||
|
|
|||
| access: RelationshipProperty = relationship("Access", uselist=False, back_populates="user") | |||
| device: RelationshipProperty = relationship("Device", uselist=False, back_populates="owner") | |||
| acknowledged_events: RelationshipProperty = relationship("Event", back_populates="acknowledger") | |||
There was a problem hiding this comment.
Mmmh, that's a tricky column to maintain I think?
We could get that information by querying the event table with the user.id. Especially for French regions were everyone uses the same login, that field value could become huge otherwise
To address #274 , this PR adds acknowledged_ts and acknowledged_by to events table